From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27652 invoked by alias); 30 May 2002 00:23:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27636 invoked from network); 30 May 2002 00:23:30 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 30 May 2002 00:23:30 -0000 Received: from romulus.sfbay.redhat.com (romulus.sfbay.redhat.com [172.16.27.251]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id RAA15335; Wed, 29 May 2002 17:23:29 -0700 (PDT) Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g4U0NNc04789; Wed, 29 May 2002 17:23:23 -0700 Date: Wed, 29 May 2002 17:37:00 -0000 From: Kevin Buettner Message-Id: <1020530002323.ZM4788@localhost.localdomain> In-Reply-To: Jason R Thorpe "Re: [PATCH/RFA] Generic OS ABI handling for PowerPC" (May 28, 5:26pm) References: <20020528122612.O22765@dr-evil.shagadelic.org> <1020528194109.ZM21642@localhost.localdomain> <20020528125247.P22765@dr-evil.shagadelic.org> <1020528204629.ZM29455@localhost.localdomain> <20020528152642.S22765@dr-evil.shagadelic.org> <1020528233517.ZM5467@localhost.localdomain> <20020528172621.C22765@dr-evil.shagadelic.org> To: Jason R Thorpe Subject: Re: [PATCH/RFA] Generic OS ABI handling for PowerPC Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-05/txt/msg01013.txt.bz2 On May 28, 5:26pm, Jason R Thorpe wrote: > Ok, new patch. Moves the ppc_sysv stuff into new ppc-sysv-tdep.c, > and updates the various .mt files. I also touched up some dependency > lists in Makefile.in. > > OK to commit? Sure, go ahead. The only nit I have is with parts of your ChangeLog entry. Entries like this one... > * ppc-linux-tdep.c (_initialize_ppc_linux_tdep, > ppc_linux_init_abi): New functions. > (ppc_sysv_abi_broken_use_struct_convention, > ppc_sysv_abi_use_struct_convention, > ppc_sysv_abi_push_arguments): Move to... ...should be formatted as follows: * ppc-linux-tdep.c (_initialize_ppc_linux_tdep) (ppc_linux_init_abi): New functions. (ppc_sysv_abi_broken_use_struct_convention) (ppc_sysv_abi_use_struct_convention) (ppc_sysv_abi_push_arguments): Move to... (Actually, I prefer the way you did it, but I've been told that it's incorrect.) Kevin