Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] rs6000-tdep.c: Add fpscr comment
@ 2002-04-30 16:38 Kevin Buettner
  0 siblings, 0 replies; only message in thread
From: Kevin Buettner @ 2002-04-30 16:38 UTC (permalink / raw)
  To: gdb-patches

I've just committed the patch below.

	* rs6000-tdep.c: Added comment describing how fpscr register
	numbers were chosen.

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.62
diff -u -p -r1.62 rs6000-tdep.c
--- rs6000-tdep.c	30 Apr 2002 00:26:43 -0000	1.62
+++ rs6000-tdep.c	30 Apr 2002 23:34:38 -0000
@@ -2026,7 +2026,21 @@ rs6000_convert_from_func_ptr_addr (CORE_
 
    Most of these register groups aren't anything formal.  I arrived at
    them by looking at the registers that occurred in more than one
-   processor. */
+   processor.
+   
+   Note: kevinb/2002-04-30: Support for the fpscr register was added
+   during April, 2002.  Slot 70 is being used for PowerPC and slot 71
+   for Power.  For PowerPC, slot 70 was unused and was already in the
+   PPC_UISA_SPRS which is ideally where fpscr should go.  For Power,
+   slot 70 was being used for "mq", so the next available slot (71)
+   was chosen.  It would have been nice to be able to make the
+   register numbers the same across processor cores, but this wasn't
+   possible without either 1) renumbering some registers for some
+   processors or 2) assigning fpscr to a really high slot that's
+   larger than any current register number.  Doing (1) is bad because
+   existing stubs would break.  Doing (2) is undesirable because it
+   would introduce a really large gap between fpscr and the rest of
+   the registers for most processors.  */
 
 /* Convenience macros for populating register arrays. */
 


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-04-30 23:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-30 16:38 [PATCH] rs6000-tdep.c: Add fpscr comment Kevin Buettner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox