Re: [PATCH] Export fill_fpxregset

[Kevin Buettner <kevinb@redhat.com>]

On Jan 10,  2:56pm, Daniel Jacobowitz wrote:

> > In this case, i386-linux-nat.c uses the native type elf_fpxregset_t, 
> > while the rest of gdb will use the portable type gdb_fpxregset_t.
> > Since they are identical, there shouldn't be a problem.
> 
> I don't think there should be a gdb_fpxregset_t.  There's no such thing
> as a portable fpxregset; PowerPC is going to have a vrregset instead,
> in fact.  How this should be handled in generic code that wants to
> manipulate regsets remains to be seen.  Ideal might be a list of
> available regset types in a struct somewhere.

In my opinion an xregset ought to just be passed as a void *.  The
underlying target code will need a method which may be called to tell
the generic code the size (for allocation and copying purposes).

If you want type safety, you can wrap the the pointer in a struct
and pass the struct.

Kevin