From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23230 invoked by alias); 10 Jan 2002 20:14:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23125 invoked from network); 10 Jan 2002 20:13:59 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 10 Jan 2002 20:13:59 -0000 Received: from cse.cygnus.com (cse.sfbay.redhat.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA18957; Thu, 10 Jan 2002 12:13:56 -0800 (PST) Received: (from kev@localhost) by cse.cygnus.com (8.11.6/8.11.6) id g0AKCk805465; Thu, 10 Jan 2002 13:12:46 -0700 Date: Thu, 10 Jan 2002 12:14:00 -0000 From: Kevin Buettner Message-Id: <1020110201246.ZM5464@localhost.localdomain> In-Reply-To: Daniel Jacobowitz "Re: [PATCH] Export fill_fpxregset" (Jan 10, 2:56pm) References: <200201092228.g09MSGl03285@reddwarf.cygnus.com> <15420.53104.770587.362588@localhost.cygnus.com> <3C3DEFCE.B5A19EFC@redhat.com> <20020110145653.B10383@nevyn.them.org> X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera) To: Daniel Jacobowitz , Michael Snyder Subject: Re: [PATCH] Export fill_fpxregset Cc: Elena Zannoni , Michael Snyder , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-01/txt/msg00249.txt.bz2 On Jan 10, 2:56pm, Daniel Jacobowitz wrote: > > In this case, i386-linux-nat.c uses the native type elf_fpxregset_t, > > while the rest of gdb will use the portable type gdb_fpxregset_t. > > Since they are identical, there shouldn't be a problem. > > I don't think there should be a gdb_fpxregset_t. There's no such thing > as a portable fpxregset; PowerPC is going to have a vrregset instead, > in fact. How this should be handled in generic code that wants to > manipulate regsets remains to be seen. Ideal might be a list of > available regset types in a struct somewhere. In my opinion an xregset ought to just be passed as a void *. The underlying target code will need a method which may be called to tell the generic code the size (for allocation and copying purposes). If you want type safety, you can wrap the the pointer in a struct and pass the struct. Kevin