PATCH : AIX build failure

PATCH : AIX build failure

[Tom Rix]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

This patch fixes a powerpc-ibm-aix4.3.3.0 build failure.
config/powerpc/aix.mt now includes the same files as
config/rs6000/aix4.mt


-
Tom Rix
GCC Engineer
trix@redhat.com



[-- Attachment #2: gdb-config-001fa.patch --]
[-- Type: text/plain, Size: 617 bytes --]

2001-12-20  Tom Rix  <trix@redhat.com>
 
 	* config/powerpc/aix.mt (TDEPFILES): Add xcoffread.o to fix a build 
 	failure.
 
diff -rcp src-old/gdb/config/powerpc/aix.mt src/gdb/config/powerpc/aix.mt
*** src-old/gdb/config/powerpc/aix.mt	Thu Dec 20 12:18:36 2001
--- src/gdb/config/powerpc/aix.mt	Thu Dec 20 12:21:40 2001
***************
*** 1,3 ****
  # Target: PowerPC running AIX
! TDEPFILES= rs6000-tdep.o ppc-linux-tdep.o solib.o solib-svr4.o
  TM_FILE= tm-ppc-aix.h
--- 1,3 ----
  # Target: PowerPC running AIX
! TDEPFILES= rs6000-tdep.o xcoffread.o ppc-linux-tdep.o solib.o solib-svr4.o
  TM_FILE= tm-ppc-aix.h

Re: PATCH : AIX build failure

[Kevin Buettner]

On Dec 20,  4:03pm, Tom Rix wrote:

> This patch fixes a powerpc-ibm-aix4.3.3.0 build failure.
> config/powerpc/aix.mt now includes the same files as
> config/rs6000/aix4.mt
>
> 2001-12-20  Tom Rix  <trix@redhat.com>
>  
>  	* config/powerpc/aix.mt (TDEPFILES): Add xcoffread.o to fix a build 
>  	failure.

I think this is the right place for it.  But, I see that xcoffread.o
is also in NATDEPFILES in config/powerpc/aix.mh.  Did you somehow try
an AIX build which used config/powerpc/aix.mt, but not
config/powerpc/aix.mh?

(BTW, you need to get yourself added to the MAINTAINERS file before
you can commit this patch.)

Kevin

Re: PATCH : AIX build failure

[Tom Rix]

Kevin Buettner wrote:

> On Dec 20,  4:03pm, Tom Rix wrote:
>
> > This patch fixes a powerpc-ibm-aix4.3.3.0 build failure.
> > config/powerpc/aix.mt now includes the same files as
> > config/rs6000/aix4.mt
> >
> > 2001-12-20  Tom Rix  <trix@redhat.com>
> >
> >       * config/powerpc/aix.mt (TDEPFILES): Add xcoffread.o to fix a build
> >       failure.
>
> I think this is the right place for it.  But, I see that xcoffread.o
> is also in NATDEPFILES in config/powerpc/aix.mh.  Did you somehow try
> an AIX build which used config/powerpc/aix.mt, but not
> config/powerpc/aix.mh?

Yes
I am doing a cross build with i686-pc-linux-gnu.

>
>
> (BTW, you need to get yourself added to the MAINTAINERS file before
> you can commit this patch.)

I will put myself at the bottom of the write with approval list.

>
>
> Kevin

--
Tom Rix
GCC Engineer
trix@redhat.com

Re: PATCH : AIX build failure

[Kevin Buettner]

On Dec 20,  4:53pm, Tom Rix wrote:

> Kevin Buettner wrote:
> 
> > On Dec 20,  4:03pm, Tom Rix wrote:
> >
> > > This patch fixes a powerpc-ibm-aix4.3.3.0 build failure.
> > > config/powerpc/aix.mt now includes the same files as
> > > config/rs6000/aix4.mt
> > >
> > > 2001-12-20  Tom Rix  <trix@redhat.com>
> > >
> > >       * config/powerpc/aix.mt (TDEPFILES): Add xcoffread.o to fix a build
> > >       failure.
> >
> > I think this is the right place for it.  But, I see that xcoffread.o
> > is also in NATDEPFILES in config/powerpc/aix.mh.  Did you somehow try
> > an AIX build which used config/powerpc/aix.mt, but not
> > config/powerpc/aix.mh?
> 
> Yes
> I am doing a cross build with i686-pc-linux-gnu.

Okay.  I think your patch should also remove xcoffread.o from aix.mh
then.

Thanks,

Kevin

Re: PATCH : AIX build failure

[Andrew Cagney]

> Kevin Buettner wrote:

>>
>> (BTW, you need to get yourself added to the MAINTAINERS file before
>> you can commit this patch.)


I take it that Kevin is suggesting that you be added.  The criteria are:


> To get recommended for the Write After Approval list you need a valid
> FSF assignment and have submitted one good patch.


so yes, ok.

	Andrew