From: Kevin Buettner <kevinb@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] i386-linux-nat.c: Use regcache_collect() in fill_gregset()
Date: Wed, 07 Nov 2001 14:37:00 -0000 [thread overview]
Message-ID: <1011118214027.ZM14027@ocotillo.lan> (raw)
In-Reply-To: Kevin Buettner <kevinb@cygnus.com> "[PATCH] i386-linux-nat.c: Use regcache_collect() in fill_gregset()" (Nov 17, 6:21pm)
On Nov 17, 6:21pm, Kevin Buettner wrote:
> I've just committed the following change...
>
> * i386-linux-nat.c (fill_gregset): Use regcache_collect() instead
> of accessing registers[] directly.
But I screwed it up. I've just committed the following patch which fixes
it...
* i386-linux-nat.c (fill_gregset): Fix botched regcache_collect()
conversion for I386_LINUX_ORIG_EAX_REGNUM.
Index: i386-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-linux-nat.c,v
retrieving revision 1.31
diff -u -p -r1.31 i386-linux-nat.c
--- i386-linux-nat.c 2001/11/18 01:19:47 1.31
+++ i386-linux-nat.c 2001/11/18 21:35:37
@@ -325,7 +325,7 @@ fill_gregset (elf_gregset_t *gregsetp, i
regcache_collect (i, regp + regmap[i]);
if (regno == -1 || regno == I386_LINUX_ORIG_EAX_REGNUM)
- regcache_collect (I386_LINUX_ORIG_EAX_REGNUM, regp + regmap[ORIG_EAX]);
+ regcache_collect (I386_LINUX_ORIG_EAX_REGNUM, regp + ORIG_EAX);
}
#ifdef HAVE_PTRACE_GETREGS
prev parent reply other threads:[~2001-11-18 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-07 9:59 Kevin Buettner
2001-11-07 14:37 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1011118214027.ZM14027@ocotillo.lan \
--to=kevinb@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox