From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-10621-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 29346 invoked by alias); 18 Nov 2001 21:40:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 29205 invoked from network); 18 Nov 2001 21:40:45 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sourceware.cygnus.com with SMTP; 18 Nov 2001 21:40:45 -0000
Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id NAA05054
	for <gdb-patches@sources.redhat.com>; Sun, 18 Nov 2001 13:40:44 -0800 (PST)
Received: (from kev@localhost)
	by cse.cygnus.com (8.9.3/8.9.3) id OAA14028
	for gdb-patches@sources.redhat.com; Sun, 18 Nov 2001 14:40:27 -0700
Date: Wed, 07 Nov 2001 14:37:00 -0000
From: Kevin Buettner <kevinb@cygnus.com>
Message-Id: <1011118214027.ZM14027@ocotillo.lan>
In-Reply-To: Kevin Buettner <kevinb@cygnus.com>
        "[PATCH] i386-linux-nat.c: Use regcache_collect() in fill_gregset()" (Nov 17,  6:21pm)
References: <1011118012136.ZM7100@ocotillo.lan>
X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera)
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] i386-linux-nat.c: Use regcache_collect() in fill_gregset()
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2001-11/txt/msg00117.txt.bz2

On Nov 17,  6:21pm, Kevin Buettner wrote:

> I've just committed the following change...
> 
> 	* i386-linux-nat.c (fill_gregset): Use regcache_collect() instead
> 	of accessing registers[] directly.

But I screwed it up.  I've just committed the following patch which fixes
it...

	* i386-linux-nat.c (fill_gregset): Fix botched regcache_collect()
	conversion for I386_LINUX_ORIG_EAX_REGNUM.

Index: i386-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-linux-nat.c,v
retrieving revision 1.31
diff -u -p -r1.31 i386-linux-nat.c
--- i386-linux-nat.c	2001/11/18 01:19:47	1.31
+++ i386-linux-nat.c	2001/11/18 21:35:37
@@ -325,7 +325,7 @@ fill_gregset (elf_gregset_t *gregsetp, i
       regcache_collect (i, regp + regmap[i]);
 
   if (regno == -1 || regno == I386_LINUX_ORIG_EAX_REGNUM)
-    regcache_collect (I386_LINUX_ORIG_EAX_REGNUM, regp + regmap[ORIG_EAX]);
+    regcache_collect (I386_LINUX_ORIG_EAX_REGNUM, regp + ORIG_EAX);
 }
 
 #ifdef HAVE_PTRACE_GETREGS