[PATCH] mi/mi-out.c: Make function declarators match earlier declarations

[PATCH] mi/mi-out.c: Make function declarators match earlier declarations

[Kevin Buettner]

I've just committed the following patch as an obvious fix.  I'm not
sure why these weren't caught sooner, but the native AIX 5 compiler
was (rightfully) complaining about the mismatch between the definition
and declarations of certain functions...

	* mi-out.c (mi_table_header, mi_field_int, mi_field_skip)
	(mi_field_string) Make function declarators match earlier
	declarations.

Index: mi/mi-out.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-out.c,v
retrieving revision 1.20
diff -u -p -r1.20 mi-out.c
--- mi-out.c	2001/07/06 03:53:11	1.20
+++ mi-out.c	2001/07/09 05:47:06
@@ -162,7 +162,7 @@ mi_table_end (struct ui_out *uiout)
 /* Specify table header */
 
 void
-mi_table_header (struct ui_out *uiout, int width, int alignment,
+mi_table_header (struct ui_out *uiout, int width, enum ui_align alignment,
 		 const char *col_name,
 		 const char *colhdr)
 {
@@ -212,8 +212,8 @@ mi_end (struct ui_out *uiout,
 /* output an int field */
 
 void
-mi_field_int (struct ui_out *uiout, int fldno, int width, int alignment,
-	      const char *fldname, int value)
+mi_field_int (struct ui_out *uiout, int fldno, int width,
+              enum ui_align alignment, const char *fldname, int value)
 {
   char buffer[20];		/* FIXME: how many chars long a %d can become? */
   struct ui_out_data *data = ui_out_data (uiout);
@@ -227,8 +227,8 @@ mi_field_int (struct ui_out *uiout, int 
 /* used to ommit a field */
 
 void
-mi_field_skip (struct ui_out *uiout, int fldno, int width, int alignment,
-	       const char *fldname)
+mi_field_skip (struct ui_out *uiout, int fldno, int width,
+               enum ui_align alignment, const char *fldname)
 {
   struct ui_out_data *data = ui_out_data (uiout);
   if (data->suppress_output)
@@ -243,7 +243,7 @@ void
 mi_field_string (struct ui_out *uiout,
 		 int fldno,
 		 int width,
-		 int align,
+		 enum ui_align align,
 		 const char *fldname,
 		 const char *string)
 {

Re: [PATCH] mi/mi-out.c: Make function declarators match earlier declarations

[Eli Zaretskii]

On Sun, 8 Jul 2001, Kevin Buettner wrote:

> I've just committed the following patch as an obvious fix.  I'm not
> sure why these weren't caught sooner, but the native AIX 5 compiler
> was (rightfully) complaining about the mismatch between the definition
> and declarations of certain functions...

It wasn't caught probably because not all compilers consider that as 
something worth complaining about, because lots of existing code mixes 
int's with enumerations.