From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>, Richard Bunt <richard.bunt@arm.com>
Cc: <gdb-patches@sourceware.org>, <nd@arm.com>
Subject: Re: [PATCH v2] Logical short circuiting with argument lists
Date: Sat, 08 Sep 2018 21:25:00 -0000 [thread overview]
Message-ID: <0f749771-b06e-ed37-0535-6e2d76d7c060@ericsson.com> (raw)
In-Reply-To: <87mustueua.fsf@tromey.com>
On 2018-09-07 11:23 PM, Tom Tromey wrote:
>>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:
>
> Thank you for the patch.
>
> Richard> koenig.exp was updated to include a testcase which exercises the
> Richard> modified skip logic in OP_VAR_VALUE, as it falls through from
> Richard> OP_ADL_FUNC.
>
> Nice, thanks.
>
> Richard> +void
> Richard> +skip_undetermined_arglist (int nargs, struct expression *exp, int *pos,
> Richard> + enum noside noside)
>
> This needs an introductory comment.
Also, you can get rid of the forward-declaration of skip_undetermined_arglist,
and the definition should be made static.
Simon
next prev parent reply other threads:[~2018-09-08 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 16:03 Richard Bunt
2018-09-04 8:26 ` [PING][PATCH " Richard Bunt
2018-09-07 22:23 ` [PATCH " Tom Tromey
2018-09-07 22:29 ` Simon Marchi
2018-09-07 22:34 ` Simon Marchi
2018-09-07 22:36 ` Tom Tromey
2018-09-08 21:25 ` Simon Marchi [this message]
2018-09-12 8:16 ` Richard Bunt
[not found] ` <87pnxjj688.fsf@tromey.com>
2018-09-12 13:04 ` Pedro Alves
2018-09-15 21:03 ` Tom Tromey
2018-09-17 18:04 ` Richard Bunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f749771-b06e-ed37-0535-6e2d76d7c060@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=richard.bunt@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox