From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95981 invoked by alias); 8 Sep 2018 21:25:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95918 invoked by uid 89); 8 Sep 2018 21:25:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:694, skip, sk:richard X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Sep 2018 21:25:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1536441933; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MmbhloUsfNVOV4ZrvCUVFIhmepmvOacB3TRT3D5sejE=; b=HHDle+HnLTZXGAlrKkcuLj37+JlyDINtWEOpd0R5LhgSN5U+Q5xGBPOTwUaSbOsF kR0Sad1PlYX7TX4A95LhDYvzQ0NUHIEjpQHwHlaWjGPzBQ7nvBF6XGb5EuU7wJak fJN6Kun2+slSllMeEDT9Fc//XciAiEUPA7EnPQjEfQM=; Received: from ESESSMB502.ericsson.se (Unknown_Domain [153.88.183.120]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 7F.27.31332.D4E349B5; Sat, 8 Sep 2018 23:25:33 +0200 (CEST) Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sat, 8 Sep 2018 23:25:32 +0200 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sat, 8 Sep 2018 23:25:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jotDkbbxLHCSDv3eeBEb6KHH8HH7uUGi3ctqwhks6jQ=; b=CCQMwgc5HaoxP5TLCWVIsBDTz5OptIV6E/d1oFQcgJ+vTon6r+lr3je5Rn4aPCDEeCKGPVamxaRCDJ3pFNgmGfdKrPeu/luS0mLGMO0ClMIoSR0O5i+SH90wCfyU0jrvpK1BK12ptBoviSY4F5s1meSHuT0pYBvtMgzn3RJpcAg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.32.129] (192.176.1.81) by DM6PR15MB2394.namprd15.prod.outlook.com (2603:10b6:5:8d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Sat, 8 Sep 2018 21:25:28 +0000 Subject: Re: [PATCH v2] Logical short circuiting with argument lists To: Tom Tromey , Richard Bunt CC: , References: <79494820-f795-ad3c-8546-0ad288cd05b0@arm.com> <87mustueua.fsf@tromey.com> From: Simon Marchi Message-ID: <0f749771-b06e-ed37-0535-6e2d76d7c060@ericsson.com> Date: Sat, 08 Sep 2018 21:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87mustueua.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00195.txt.bz2 On 2018-09-07 11:23 PM, Tom Tromey wrote: >>>>>> "Richard" == Richard Bunt writes: > > Thank you for the patch. > > Richard> koenig.exp was updated to include a testcase which exercises the > Richard> modified skip logic in OP_VAR_VALUE, as it falls through from > Richard> OP_ADL_FUNC. > > Nice, thanks. > > Richard> +void > Richard> +skip_undetermined_arglist (int nargs, struct expression *exp, int *pos, > Richard> + enum noside noside) > > This needs an introductory comment. Also, you can get rid of the forward-declaration of skip_undetermined_arglist, and the definition should be made static. Simon