From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>,
Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [committed][gdb/testsuite] Make gdb.base/dbx.exp more robust
Date: Thu, 11 Jun 2020 13:16:43 +0100 [thread overview]
Message-ID: <0ecc1f0d-2941-4b5c-e74e-6320ebe646ca@redhat.com> (raw)
In-Reply-To: <9352af37-7ed7-661c-11f1-59fbc6a886e9@suse.de>
On 6/11/20 1:11 PM, Tom de Vries wrote:
> [ was: Re: [PATCH 3/3][gdb/testsuite] Warn about leaked global array ]
>
> On 04-06-2020 13:40, Tom de Vries wrote:
>>> BTW, global variables alone aren't the full scope of the
>>> bleeding between testcases. There's also the case of
>>> testcases overriding procedures, like gdb.base/dbx.exp,
>>> but those are perhaps rare enough that we can continue
>>> handling it "manually" as before.
>> AFAICT, that test-case does an effort to undo the override, though I'm
>> not sure how certain it is that the undo will be executed.
>
> I've committed patch below to make sure the undo is executed (and
> similar for GDBFLAGS).
Nice.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-06-11 12:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 16:30 [PATCH 3/3][gdb/testsuite] Warn about leaked global array Tom de Vries
2020-05-22 20:15 ` Tom Tromey
2020-06-02 13:08 ` Tom de Vries
2020-06-02 15:38 ` Andrew Burgess
2020-06-02 15:52 ` Andrew Burgess
2020-06-02 16:31 ` Tom de Vries
2020-06-02 17:01 ` Andrew Burgess
2020-06-02 20:18 ` Andrew Burgess
2020-06-03 8:47 ` Tom de Vries
2020-06-03 9:38 ` Tom de Vries
2020-06-03 10:09 ` Tom de Vries
2020-06-03 10:24 ` Tom de Vries
2020-06-03 12:54 ` Andrew Burgess
2020-06-03 15:35 ` Tom de Vries
2020-06-04 11:16 ` Pedro Alves
2020-06-04 12:29 ` Tom de Vries
2020-06-12 13:11 ` [committed] gdb/testsuite: Prevent globals leaking between test scripts Tom de Vries
2020-06-03 9:49 ` [PATCH 3/3][gdb/testsuite] Warn about leaked global array Pedro Alves
2020-06-04 11:40 ` Tom de Vries
2020-06-05 10:06 ` [PATCH][gdb/testsuite] Don't leak tuiterm.exp spawn override Tom de Vries
2020-06-11 13:55 ` Tom Tromey
2020-06-12 11:36 ` [committed][gdb/testsuite] " Tom de Vries
2020-06-15 19:46 ` Tom Tromey
2020-06-17 14:55 ` Tom de Vries
2020-06-17 15:28 ` Andreas Schwab
2020-06-11 12:11 ` [committed][gdb/testsuite] Make gdb.base/dbx.exp more robust Tom de Vries
2020-06-11 12:16 ` Pedro Alves [this message]
2020-06-11 14:39 ` Simon Marchi
2020-06-11 14:52 ` Tom de Vries
2020-06-11 14:59 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ecc1f0d-2941-4b5c-e74e-6320ebe646ca@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox