From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id C9DFF3840C3D for ; Thu, 11 Jun 2020 12:16:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9DFF3840C3D Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-SqeaMtT6OxiBR3kpjEBXeQ-1; Thu, 11 Jun 2020 08:16:47 -0400 X-MC-Unique: SqeaMtT6OxiBR3kpjEBXeQ-1 Received: by mail-wr1-f71.google.com with SMTP id z10so2513800wrs.2 for ; Thu, 11 Jun 2020 05:16:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=moxUD3hk1jJt8crzRSFB2tdsdzuG2f9DcJBEKX9a/n8=; b=Pvjnwe7p9ARnX9jgMKnejnnwC5ARzVXinyMJrn/GqB6qnmmeVyqfC1HDA+LnkJulTG Z40GjIp678yy71jTW43GyntNtsVASv/IXvxcFTFGY2EFNQYkXTNSqp4D0LGyu6VX+WVL ClPrqvPIZfrrafROiRQ2xojmBGJIdScqMWce75PM50bfeX1uJRdr+dD8gQqNlgTxzldV VJ3E57+Ad/+pug1UuS1Rkwv1TUagoosRSMdVMZ+ls76w/4V+J4nmQeCKYnA0JvTFsj9K OBDLf12J4SaYntZbzBJfpXFtGPh+Ip2lenhLE8EaHmEScFfkU4lgHxhN+7WoO1XDg+HZ uMxg== X-Gm-Message-State: AOAM530KGev5AGpE9rhAo4N197zEuCZzvbMirfJG5fyKrMsCCF07c9aH Ijl40kJgoSlpgMvYGT6FROkcz1pJlumNtwUYxaiUl+nJUdX9/FKTTkj2Xpd2kyGJ84srLrD3Z+3 TCFNH1gFIupCOjr4aUE69Kw== X-Received: by 2002:a7b:ce15:: with SMTP id m21mr8054058wmc.117.1591877805760; Thu, 11 Jun 2020 05:16:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfFdS8buz+O+t0KOgVRfa731GpP0MhwkD58tQPn+JEKMh+H2dDeRqkSJUpkoJ0uLqfJOLf8g== X-Received: by 2002:a7b:ce15:: with SMTP id m21mr8054043wmc.117.1591877805584; Thu, 11 Jun 2020 05:16:45 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id s8sm4994279wrg.50.2020.06.11.05.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 05:16:44 -0700 (PDT) Subject: Re: [committed][gdb/testsuite] Make gdb.base/dbx.exp more robust To: Tom de Vries , Andrew Burgess References: <20200519163004.GA9045@delia> <20200602153830.GZ3522@embecosm.com> <72b3c10c-d316-9a0e-13e9-56dee7c765a7@redhat.com> <5d6277ac-76ea-5f47-ab9e-7da58fbddd6e@suse.de> <9352af37-7ed7-661c-11f1-59fbc6a886e9@suse.de> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <0ecc1f0d-2941-4b5c-e74e-6320ebe646ca@redhat.com> Date: Thu, 11 Jun 2020 13:16:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <9352af37-7ed7-661c-11f1-59fbc6a886e9@suse.de> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 12:16:51 -0000 On 6/11/20 1:11 PM, Tom de Vries wrote: > [ was: Re: [PATCH 3/3][gdb/testsuite] Warn about leaked global array ] > > On 04-06-2020 13:40, Tom de Vries wrote: >>> BTW, global variables alone aren't the full scope of the >>> bleeding between testcases. There's also the case of >>> testcases overriding procedures, like gdb.base/dbx.exp, >>> but those are perhaps rare enough that we can continue >>> handling it "manually" as before. >> AFAICT, that test-case does an effort to undo the override, though I'm >> not sure how certain it is that the undo will be executed. > > I've committed patch below to make sure the undo is executed (and > similar for GDBFLAGS). Nice. Thanks, Pedro Alves