From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix shlib compilation with target board unix/-pie/-fPIE
Date: Sat, 19 Dec 2020 21:29:08 -0500 [thread overview]
Message-ID: <0ddc6cbe-880e-7cb7-5754-6a503dcaf80d@polymtl.ca> (raw)
In-Reply-To: <9f2a5364-9651-2842-2d64-439ef14957fd@suse.de>
On 2020-12-19 12:44 p.m., Tom de Vries wrote:
> I thought this over a bit more, and came to the realization that what
> this does is similar to save_vars, only for target board_info.
>
> So, how about this refactoring?
Makes sense, but I would opt for a separate save_target_board_info proc
instead, it's a bit easier to remember how to use, and will keep each
implementation simple.
Simon
next prev parent reply other threads:[~2020-12-20 2:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 16:41 Tom de Vries
2020-12-14 17:21 ` Simon Marchi
2020-12-16 17:22 ` Tom de Vries
2020-12-19 17:44 ` Tom de Vries
2020-12-20 2:29 ` Simon Marchi via Gdb-patches [this message]
2020-12-20 8:37 ` [committed][gdb/testsuite] Add save_target_board_info Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ddc6cbe-880e-7cb7-5754-6a503dcaf80d@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox