From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OPEhIw+33l+KJwAAWB0awg (envelope-from ) for ; Sat, 19 Dec 2020 21:29:35 -0500 Received: by simark.ca (Postfix, from userid 112) id 8E10D1F0AA; Sat, 19 Dec 2020 21:29:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 172681E590 for ; Sat, 19 Dec 2020 21:29:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C5A83858026; Sun, 20 Dec 2020 02:29:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C5A83858026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608431374; bh=ICPA0ju1f/3Yh6h7efYS/QNO1v8XcbSJPqXIc13jQqY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VdXFHlegTyfqzyKDeHAM0JZSsdKIsLKwVNyVJDkKoD48zc7QCVRPOdh9VaOcoH5bY dPX5WcbI8w/7doYXX7w531T3BgYFGZ/mZjvw40/2RWpMJkqOe8jNBriXVMlv/vEMaG Iq/RgFMI4wUec0ruu0r3h4X/nKQrp/azuN0Oc0/w= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 23BD13858D37 for ; Sun, 20 Dec 2020 02:29:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23BD13858D37 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BK2T9hR008574 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Dec 2020 21:29:14 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BK2T9hR008574 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4F75C1E590; Sat, 19 Dec 2020 21:29:09 -0500 (EST) Subject: Re: [PATCH][gdb/testsuite] Fix shlib compilation with target board unix/-pie/-fPIE To: Tom de Vries , Simon Marchi , gdb-patches@sourceware.org References: <20201213164131.GA7699@delia> <60fb40c8-73ca-e6de-e45f-805fba548f88@simark.ca> <1a23f50f-bf4f-ae09-7ff5-b23e59d6438b@suse.de> <9f2a5364-9651-2842-2d64-439ef14957fd@suse.de> Message-ID: <0ddc6cbe-880e-7cb7-5754-6a503dcaf80d@polymtl.ca> Date: Sat, 19 Dec 2020 21:29:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <9f2a5364-9651-2842-2d64-439ef14957fd@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 20 Dec 2020 02:29:09 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-19 12:44 p.m., Tom de Vries wrote: > I thought this over a bit more, and came to the realization that what > this does is similar to save_vars, only for target board_info. > > So, how about this refactoring? Makes sense, but I would opt for a separate save_target_board_info proc instead, it's a bit easier to remember how to use, and will keep each implementation simple. Simon