From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove a cleanup from parse_expression_for_completion
Date: Fri, 16 Feb 2018 23:27:00 -0000 [thread overview]
Message-ID: <0cbcbff07cb649201177fa01e92327e0@polymtl.ca> (raw)
In-Reply-To: <20180216230212.18553-1-tom@tromey.com>
On 2018-02-16 18:02, Tom Tromey wrote:
> This removes a cleanup from parse_expression_for_completion, by
> changing various expression-completion functions to use std::string
> rather than explicit malloc+free.
That looks good to me. You can go a bit further if you want and make
add_struct_fields take a const std::string reference as well.
Simon
next prev parent reply other threads:[~2018-02-16 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 23:02 Tom Tromey
2018-02-16 23:27 ` Simon Marchi [this message]
2018-02-20 4:39 ` Tom Tromey
2018-02-20 5:02 ` Tom Tromey
2018-02-20 20:23 ` Tom Tromey
2018-02-21 3:46 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cbcbff07cb649201177fa01e92327e0@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox