From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116025 invoked by alias); 16 Feb 2018 23:27:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115922 invoked by uid 89); 16 Feb 2018 23:27:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Feb 2018 23:27:22 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w1GNRFo8028479 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 16 Feb 2018 18:27:20 -0500 Received: by simark.ca (Postfix, from userid 112) id A85ED1E76C; Fri, 16 Feb 2018 18:27:15 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 7CB341E093; Fri, 16 Feb 2018 18:27:14 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 16 Feb 2018 23:27:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Remove a cleanup from parse_expression_for_completion In-Reply-To: <20180216230212.18553-1-tom@tromey.com> References: <20180216230212.18553-1-tom@tromey.com> Message-ID: <0cbcbff07cb649201177fa01e92327e0@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 16 Feb 2018 23:27:15 +0000 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00224.txt.bz2 On 2018-02-16 18:02, Tom Tromey wrote: > This removes a cleanup from parse_expression_for_completion, by > changing various expression-completion functions to use std::string > rather than explicit malloc+free. That looks good to me. You can go a bit further if you want and make add_struct_fields take a const std::string reference as well. Simon