Re: [PATCH 6/8] DWARF-5: call sites

[Pedro Alves <palves@redhat.com>]

On 02/12/2017 08:23 PM, Jan Kratochvil wrote:

>  /* OP_LAST is followed by an integer in the next exp_element.
> diff --git a/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp b/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp
> index c0072ac..aa14856 100644
> --- a/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp
> @@ -19,7 +19,7 @@ set opts {}
>  if [info exists COMPILE] {
>      # make check RUNTESTFLAGS="gdb.arch/amd64-entry-value-param.exp COMPILE=1"
>      set srcfile ${srcfile2}
> -    lappend opts debug optimize=-O2
> +    lappend opts optimize=-O2 additional_flags=-gdwarf-5

Did you mean to update the .S file?

I wonder whether it makes sense to run the test twice, once against
the current .S file using the GNU version of the opcodes, and
another against standard DWARF5 opcodes.  That raises the question
of why we don't do that with the c based tests, where we'll handle
whatever format the compiler outputs.  So maybe not go there...

>  } elseif { ![istarget x86_64-*-* ] || ![is_lp64_target] } {
>      verbose "Skipping amd64-entry-value-param."
>      return

Otherwise LGTM.

Thanks,
Pedro Alves