From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34930 invoked by alias); 17 Feb 2017 11:57:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34896 invoked by uid 89); 17 Feb 2017 11:57:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=raises X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Feb 2017 11:57:45 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74A21C056800; Fri, 17 Feb 2017 11:57:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1HBvh05012128; Fri, 17 Feb 2017 06:57:44 -0500 Subject: Re: [PATCH 6/8] DWARF-5: call sites To: Jan Kratochvil , gdb-patches@sourceware.org References: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> <148693100920.9024.1248500668176010687.stgit@host1.jankratochvil.net> Cc: Victor Leschuk From: Pedro Alves Message-ID: <0bcfa83d-33bf-14dd-6922-527913c76675@redhat.com> Date: Fri, 17 Feb 2017 11:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <148693100920.9024.1248500668176010687.stgit@host1.jankratochvil.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00470.txt.bz2 On 02/12/2017 08:23 PM, Jan Kratochvil wrote: > /* OP_LAST is followed by an integer in the next exp_element. > diff --git a/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp b/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp > index c0072ac..aa14856 100644 > --- a/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp > +++ b/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp > @@ -19,7 +19,7 @@ set opts {} > if [info exists COMPILE] { > # make check RUNTESTFLAGS="gdb.arch/amd64-entry-value-param.exp COMPILE=1" > set srcfile ${srcfile2} > - lappend opts debug optimize=-O2 > + lappend opts optimize=-O2 additional_flags=-gdwarf-5 Did you mean to update the .S file? I wonder whether it makes sense to run the test twice, once against the current .S file using the GNU version of the opcodes, and another against standard DWARF5 opcodes. That raises the question of why we don't do that with the c based tests, where we'll handle whatever format the compiler outputs. So maybe not go there... > } elseif { ![istarget x86_64-*-* ] || ![is_lp64_target] } { > verbose "Skipping amd64-entry-value-param." > return Otherwise LGTM. Thanks, Pedro Alves