From: Pedro Alves <palves@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Cc: jan.kratochvil@redhat.com
Subject: Re: [PATCH] btrace, testsuite: fix assembly source file selection
Date: Tue, 26 Jul 2016 08:41:00 -0000 [thread overview]
Message-ID: <09802ae1-c1b5-993f-5181-d1ba1848a9b2@redhat.com> (raw)
In-Reply-To: <1469516752-32313-1-git-send-email-markus.t.metzger@intel.com>
On 07/26/2016 08:05 AM, Markus Metzger wrote:
> Some btrace tests use assembly source files. They use the target triplet to
> distinguish between x86_64 and ia32 ISA. This does not work for -m32 tests
> without setting the target triplet to i686-?-?.
>
> Instead use is_amd64_regs_target to distinguish between x86_64 and ia32 ISA.
>
> See also https://sourceware.org/ml/gdb-patches/2016-07/msg00256.html.
>
> 2016-07-26 Markus Metzger <markus.t.metzger@intel.com>
>
> testsuite/
> * gdb.btrace/record_goto.exp: Use is_amd64_regs_target for selecting
> assembly source files.
> * gdb.btrace/stepi.exp: Use is_amd64_regs_target for selecting
> assembly source files.
> * gdb.btrace/tailcall.exp: Use is_amd64_regs_target for selecting
> assembly source files.
> * gdb.btrace/tailcall-only.exp: Use is_amd64_regs_target for selecting
> assembly source files.
LGTM.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-07-26 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 7:39 Markus Metzger
2016-07-26 8:41 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09802ae1-c1b5-993f-5181-d1ba1848a9b2@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox