From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4067 invoked by alias); 26 Jul 2016 08:41:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4053 invoked by uid 89); 26 Jul 2016 08:41:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:1469516, H*MI:sk:1469516, H*f:sk:1469516, 2016-07-26 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 26 Jul 2016 08:41:28 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBB9462673; Tue, 26 Jul 2016 08:41:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6Q8fPpo014937; Tue, 26 Jul 2016 04:41:25 -0400 Subject: Re: [PATCH] btrace, testsuite: fix assembly source file selection To: Markus Metzger , gdb-patches@sourceware.org References: <1469516752-32313-1-git-send-email-markus.t.metzger@intel.com> Cc: jan.kratochvil@redhat.com From: Pedro Alves Message-ID: <09802ae1-c1b5-993f-5181-d1ba1848a9b2@redhat.com> Date: Tue, 26 Jul 2016 08:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1469516752-32313-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-07/txt/msg00341.txt.bz2 On 07/26/2016 08:05 AM, Markus Metzger wrote: > Some btrace tests use assembly source files. They use the target triplet to > distinguish between x86_64 and ia32 ISA. This does not work for -m32 tests > without setting the target triplet to i686-?-?. > > Instead use is_amd64_regs_target to distinguish between x86_64 and ia32 ISA. > > See also https://sourceware.org/ml/gdb-patches/2016-07/msg00256.html. > > 2016-07-26 Markus Metzger > > testsuite/ > * gdb.btrace/record_goto.exp: Use is_amd64_regs_target for selecting > assembly source files. > * gdb.btrace/stepi.exp: Use is_amd64_regs_target for selecting > assembly source files. > * gdb.btrace/tailcall.exp: Use is_amd64_regs_target for selecting > assembly source files. > * gdb.btrace/tailcall-only.exp: Use is_amd64_regs_target for selecting > assembly source files. LGTM. Thanks, Pedro Alves