From: Pedro Alves <palves@redhat.com>
To: Trent Piepho <tpiepho@impinj.com>, "simark@simark.ca" <simark@simark.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Record ARM THUMB2 PLD/PLI cache instructions
Date: Wed, 03 Oct 2018 17:19:00 -0000 [thread overview]
Message-ID: <09742ef7-adce-560b-bb21-c91f95a87dda@redhat.com> (raw)
In-Reply-To: <1538526847.6709.35.camel@impinj.com>
On 10/03/2018 01:34 AM, Trent Piepho wrote:
> Sorry, not that motivated. I wanted to make reverse debugging work on
> ARM, and it works for me now. Don't really want to dive into adding
> more to the self tests, which I've never used. There's really no call
> to do that on company time anyway, while for reverse debugging there
> was.
Those tests in question _are_ about reverse debugging, and adding
tests can be considered (and often required) part of a patch.
arm_record_test doesn't cover many instructions today because when
record support was added, we didn't have the self testing
infrastructure in place yet. See:
https://sourceware.org/ml/gdb-patches/2017-03/msg00031.html
Can't tell whether adding self tests for these instructions would
be really useful, but if you ever want to try it, it's quite easy
to trigger those tests -- type "maint selftest arm-record" in gdb.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-10-03 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 23:05 Trent Piepho
2018-09-30 14:22 ` Simon Marchi
2018-10-01 22:05 ` Trent Piepho
2018-10-02 17:19 ` Simon Marchi
2018-10-03 0:34 ` Trent Piepho
2018-10-03 17:19 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09742ef7-adce-560b-bb21-c91f95a87dda@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox