From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75997 invoked by alias); 3 Oct 2018 17:19:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75983 invoked by uid 89); 3 Oct 2018 17:19:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:967, company X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Oct 2018 17:19:16 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D017330842AE; Wed, 3 Oct 2018 17:19:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1F336608C; Wed, 3 Oct 2018 17:19:13 +0000 (UTC) Subject: Re: [PATCH] Record ARM THUMB2 PLD/PLI cache instructions To: Trent Piepho , "simark@simark.ca" References: <20180928230437.4329-1-tpiepho@impinj.com> <1538431511.6709.18.camel@impinj.com> <1538526847.6709.35.camel@impinj.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <09742ef7-adce-560b-bb21-c91f95a87dda@redhat.com> Date: Wed, 03 Oct 2018 17:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1538526847.6709.35.camel@impinj.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00073.txt.bz2 On 10/03/2018 01:34 AM, Trent Piepho wrote: > Sorry, not that motivated. I wanted to make reverse debugging work on > ARM, and it works for me now. Don't really want to dive into adding > more to the self tests, which I've never used. There's really no call > to do that on company time anyway, while for reverse debugging there > was. Those tests in question _are_ about reverse debugging, and adding tests can be considered (and often required) part of a patch. arm_record_test doesn't cover many instructions today because when record support was added, we didn't have the self testing infrastructure in place yet. See: https://sourceware.org/ml/gdb-patches/2017-03/msg00031.html Can't tell whether adding self tests for these instructions would be really useful, but if you ever want to try it, it's quite easy to trigger those tests -- type "maint selftest arm-record" in gdb. Thanks, Pedro Alves