Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: "Paul E. Murphy" <murphyp@linux.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2] gnulib: update to 776af40e0
Date: Fri, 22 Jan 2021 15:40:14 -0500	[thread overview]
Message-ID: <094bb0f3-f8db-d9a7-65e1-b9ef7564a151@polymtl.ca> (raw)
In-Reply-To: <20210122195545.2401220-1-murphyp@linux.ibm.com>

Thanks, branch updated:

https://sourceware.org/git/?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/simark/update-gnulib

On 2021-01-22 2:55 p.m., Paul E. Murphy wrote:
> Changes generated by rerunning are left out as the
> resulting patch is too big for the mailing list.
> 
> Likewise, tested compilation on x86 and ppc64le,
> and I do not have commit access, but I do have
> gnu copyright assignment.
> 
> V2 updates:
> 
> Apply suggested fixes from Simon Marchi and
> Christian Biesinger for unoptimized gcc builds
> and mingw.
> 
> ---8<---
> 
> This fixes PR27184, a failure to compile gdb due to
> cdefs.h being out of sync with glibc on ppc64le targets
> which are compiled with -mabi=ieeelongdouble and glibc
> 2.32.
> 
> Likewise, update usage of _GL_ATTRIBUTE_FORMAT_PRINTF to
> _GL_ATTRIBUTE_FORMAT_PRINTF_STANDARD.
> 
> Likewise, disable newly added rpl_free gnulib api in
> gdbserver support libraries.
> 
> Likewise, undefine read/write macros before redefining them
> on mingw targets.
> 
> Likewise, wrap C++ usage of free with GNULIB_NAMESPACE namespace
> as needed.
> ---
>  gdbserver/ChangeLog       | 7 +++++++
>  gdbserver/Makefile.in     | 2 +-
>  gdbserver/remote-utils.cc | 4 ++++
>  gdbsupport/ChangeLog      | 7 +++++++
>  gdbsupport/common-defs.h  | 4 ++--
>  gdbsupport/common-utils.h | 6 +++++-
>  gnulib/ChangeLog          | 5 +++++
>  gnulib/update-gnulib.sh   | 2 +-
>  8 files changed, 32 insertions(+), 5 deletions(-)
> 
> diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
> index 3323ecfbf89..8aa82967471 100644
> --- a/gdbserver/ChangeLog
> +++ b/gdbserver/ChangeLog
> @@ -1,3 +1,10 @@
> +2021-01-22  Paul E. Murphy <murphyp@linux.ibm.com>
> +
> +	* Makefile.in (UNDO_GNULIB_CFLAGS): disable
> +	gnulib free replacement too.
> +	* common-defs.h [USE_WIN32API](read, write): undefine
> +	gnulib versions before defining these macros.

Note: use capital letters at beginning of the sentences.

> diff --git a/gnulib/ChangeLog b/gnulib/ChangeLog
> index 909df781797..8adb8156518 100644
> --- a/gnulib/ChangeLog
> +++ b/gnulib/ChangeLog
> @@ -1,3 +1,8 @@
> +2021-01-22  Paul E. Murphy  <murphyp@linux.ibm.com>
> +	* update-gnulib.sh (GNULIB_COMMIT_SHA1): Bump to
> +	776af40e09b476a41073131a90022572f448c189.
> +	* Makefile.in, config.in, configure, import/*: Re-generate.

Missing line after the name/email entry.

No need to send a new version for that, whoever pushes can fix that.

Simon

  reply	other threads:[~2021-01-22 20:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 19:55 Paul E. Murphy via Gdb-patches
2021-01-22 20:40 ` Simon Marchi via Gdb-patches [this message]
2021-01-25 13:15   ` Christian Biesinger via Gdb-patches
2021-02-05 17:29 ` Paul E Murphy via Gdb-patches
2021-02-05 18:06   ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=094bb0f3-f8db-d9a7-65e1-b9ef7564a151@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=murphyp@linux.ibm.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox