Re: [PATCHv2] gnulib: update to 776af40e0

Simon Marchi via Gdb-patches
2021-01-22T20:40:27Z

Thanks, branch updated:

https://sourceware.org/git/?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/simark/update-gnulib

On 2021-01-22 2:55 p.m., Paul E. Murphy wrote:
> Changes generated by rerunning are left out as the
> resulting patch is too big for the mailing list.
>
> Likewise, tested compilation on x86 and ppc64le,
> and I do not have commit access, but I do have
> gnu copyright assignment.
>
> V2 updates:
>
> Apply suggested fixes from Simon Marchi and
> Christian Biesinger for unoptimized gcc builds
> and mingw.
>
> ---8<---
>
> This fixes PR27184, a failure to compile gdb due to
> cdefs.h being out of sync with glibc on ppc64le targets
> which are compiled with -mabi=ieeelongdouble and glibc
> 2.32.
>
> Likewise, update usage of _GL_ATTRIBUTE_FORMAT_PRINTF to
> _GL_ATTRIBUTE_FORMAT_PRINTF_STANDARD.
>
> Likewise, disable newly added rpl_free gnulib api in
> gdbserver support libraries.
>
> Likewise, undefine read/write macros before redefining them
> on mingw targets.
>
> Likewise, wrap C++ usage of free with GNULIB_NAMESPACE namespace
> as needed.
> ---
> gdbserver/ChangeLog | 7 +++++++
> gdbserver/Makefile.in | 2 +-
> gdbserver/remote-utils.cc | 4 ++++
> gdbsupport/ChangeLog | 7 +++++++
> gdbsupport/common-defs.h | 4 ++--
> gdbsupport/common-utils.h | 6 +++++-
> gnulib/ChangeLog | 5 +++++
> gnulib/update-gnulib.sh | 2 +-
> 8 files changed, 32 insertions(+), 5 deletions(-)
>
> diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
> index 3323ecfbf89..8aa82967471 100644
> --- a/gdbserver/ChangeLog
> +++ b/gdbserver/ChangeLog
> @@ -1,3 +1,10 @@
> +2021-01-22 Paul E. Murphy <murphyp@linux.ibm.com>
> +
> + * Makefile.in (UNDO_GNULIB_CFLAGS): disable
> + gnulib free replacement too.
> + * common-defs.h [USE_WIN32API](read, write): undefine
> + gnulib versions before defining these macros.

Note: use capital letters at beginning of the sentences.

> diff --git a/gnulib/ChangeLog b/gnulib/ChangeLog
> index 909df781797..8adb8156518 100644
> --- a/gnulib/ChangeLog
> +++ b/gnulib/ChangeLog
> @@ -1,3 +1,8 @@
> +2021-01-22 Paul E. Murphy <murphyp@linux.ibm.com>
> + * update-gnulib.sh (GNULIB_COMMIT_SHA1): Bump to
> + 776af40e09b476a41073131a90022572f448c189.
> + * Makefile.in, config.in, configure, import/*: Re-generate.

Missing line after the name/email entry.

No need to send a new version for that, whoever pushes can fix that.

Simon