From: Luis Machado <luis.machado@linaro.org>
To: "Raza, Saqlain" <Saqlain_Raza@mentor.com>, gdb-patches@sourceware.org
Cc: taimoor_mirza@mentor.com
Subject: Re: [PATCH 0/2] Improved variable object invalidation in GDB
Date: Tue, 22 Oct 2019 12:54:00 -0000 [thread overview]
Message-ID: <081b0999-9402-046c-6ad8-25ef7e68e1c1@linaro.org> (raw)
In-Reply-To: <1571306592-24472-1-git-send-email-Saqlain_Raza@mentor.com>
Hi,
Before reviewing the patch itself, could you please expand, with more
detail, what the use case is for this particular fix?
It seems to be the same patch Taimoor sent a while ago, so in order to
improve its chances of getting accepted, it would be nice to have a bit
more background.
In particular, adding varobj bits to objfiles.[c] is a bit strange.
Varobj access seems to be restricted to core varobj implementations and
language support only.
It may be a sign that something more fundamental is missing, like an
interface of some kind, an observer or a notification.
Better understanding the use case will allow us to determine where/how
exactly this should be fixed.
Luis
On 10/17/19 7:03 AM, Raza, Saqlain wrote:
> Hi,
> This patch series improves variable object invalidation in GDB.
>
> This is a followup to the patch series submission made in https://sourceware.org/ml/gdb-patches/2015-04/msg00598.html . This problem still holds in the latest GDB master.
>
> Raza, Saqlain (2):
> Fix varobj updation after symbol removal
> Testsuite for varobj updation after symbol removal
>
> gdb/ChangeLog | 13 ++
> gdb/objfiles.c | 19 ++
> gdb/testsuite/ChangeLog | 11 +
> gdb/testsuite/gdb.mi/mi-var-invalidate.exp | 68 ++++++
> gdb/testsuite/gdb.mi/sym-file-lib.c | 28 +++
> gdb/testsuite/gdb.mi/sym-file-loader.c | 355 +++++++++++++++++++++++++++++
> gdb/testsuite/gdb.mi/sym-file-loader.h | 101 ++++++++
> gdb/testsuite/gdb.mi/sym-file-main.c | 86 +++++++
> gdb/varobj.c | 35 +++
> gdb/varobj.h | 4 +
> 10 files changed, 720 insertions(+)
> create mode 100644 gdb/testsuite/gdb.mi/sym-file-lib.c
> create mode 100644 gdb/testsuite/gdb.mi/sym-file-loader.c
> create mode 100644 gdb/testsuite/gdb.mi/sym-file-loader.h
> create mode 100644 gdb/testsuite/gdb.mi/sym-file-main.c
>
next prev parent reply other threads:[~2019-10-22 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 10:03 Raza, Saqlain
2019-10-17 10:03 ` [PATCH 2/2] Testsuite for varobj updation after symbol removal Raza, Saqlain
2019-10-22 6:47 ` [PING][PATCH " Saqlain Raza
2019-10-17 10:03 ` [PATCH 1/2] Fix " Raza, Saqlain
2019-10-22 6:46 ` [PING][PATCH " Saqlain Raza
2019-10-22 6:45 ` [PING][PATCH 0/2] Improved variable object invalidation in GDB Saqlain Raza
2019-10-22 12:54 ` Luis Machado [this message]
2019-11-07 7:50 ` [PATCH " Saqlain Raza
2019-12-03 9:46 ` [PING][PATCH " Saqlain Raza
-- strict thread matches above, loose matches on Subject: below --
2015-04-16 3:33 [PATCH " Taimoor Mirza
2014-06-27 10:14 Taimoor Mirza
2014-07-13 7:49 ` Taimoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=081b0999-9402-046c-6ad8-25ef7e68e1c1@linaro.org \
--to=luis.machado@linaro.org \
--cc=Saqlain_Raza@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=taimoor_mirza@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox