From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13328 invoked by alias); 22 Oct 2019 12:54:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13280 invoked by uid 89); 22 Oct 2019 12:54:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=reviewing X-HELO: mail-qk1-f196.google.com Received: from mail-qk1-f196.google.com (HELO mail-qk1-f196.google.com) (209.85.222.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 12:54:04 +0000 Received: by mail-qk1-f196.google.com with SMTP id u184so16106303qkd.4 for ; Tue, 22 Oct 2019 05:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sf05/wWLZBvCMSi9vzVWrSk1qnlDJtxi/ECUbNGTFGw=; b=BXnV7Wr8sPIxFPl51fB8F3VjAx9ShDtHp38UVrqpHII6c/1ldAsPq+v2KIzkQb4jzL gSCs39ME0r3ylnmuOfa2nZ43B4FyNT8MogFr5X71JpcKR60fZ23ZuZRyM/OWO6tJgidl rQ2nMV37NjnVlBTC0B2mSgcTI1rq2LAlXpoFc5mjdD/XhPistEy6C9VkfHOEeibQRciH rcAW1HKY/Lg3gvV7RCceXr4bFVbsuwqJqkfdXyqRmxeXwp56vW831DURgwzWzWlKlJ+8 cD4VwESPFY3KKtBDsVPCq+kHW+vXBfSOz+9If6SxbH9xE1g4gt9DXw55xqpnmSKH/OlB 8luQ== Return-Path: Received: from [192.168.15.21] (201-42-175-128.dsl.telesp.net.br. [201.42.175.128]) by smtp.gmail.com with ESMTPSA id q17sm6050876qkm.65.2019.10.22.05.54.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Oct 2019 05:54:01 -0700 (PDT) Subject: Re: [PATCH 0/2] Improved variable object invalidation in GDB To: "Raza, Saqlain" , gdb-patches@sourceware.org Cc: taimoor_mirza@mentor.com References: <1571306592-24472-1-git-send-email-Saqlain_Raza@mentor.com> From: Luis Machado Message-ID: <081b0999-9402-046c-6ad8-25ef7e68e1c1@linaro.org> Date: Tue, 22 Oct 2019 12:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1571306592-24472-1-git-send-email-Saqlain_Raza@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00789.txt.bz2 Hi, Before reviewing the patch itself, could you please expand, with more detail, what the use case is for this particular fix? It seems to be the same patch Taimoor sent a while ago, so in order to improve its chances of getting accepted, it would be nice to have a bit more background. In particular, adding varobj bits to objfiles.[c] is a bit strange. Varobj access seems to be restricted to core varobj implementations and language support only. It may be a sign that something more fundamental is missing, like an interface of some kind, an observer or a notification. Better understanding the use case will allow us to determine where/how exactly this should be fixed. Luis On 10/17/19 7:03 AM, Raza, Saqlain wrote: > Hi, > This patch series improves variable object invalidation in GDB. > > This is a followup to the patch series submission made in https://sourceware.org/ml/gdb-patches/2015-04/msg00598.html . This problem still holds in the latest GDB master. > > Raza, Saqlain (2): > Fix varobj updation after symbol removal > Testsuite for varobj updation after symbol removal > > gdb/ChangeLog | 13 ++ > gdb/objfiles.c | 19 ++ > gdb/testsuite/ChangeLog | 11 + > gdb/testsuite/gdb.mi/mi-var-invalidate.exp | 68 ++++++ > gdb/testsuite/gdb.mi/sym-file-lib.c | 28 +++ > gdb/testsuite/gdb.mi/sym-file-loader.c | 355 +++++++++++++++++++++++++++++ > gdb/testsuite/gdb.mi/sym-file-loader.h | 101 ++++++++ > gdb/testsuite/gdb.mi/sym-file-main.c | 86 +++++++ > gdb/varobj.c | 35 +++ > gdb/varobj.h | 4 + > 10 files changed, 720 insertions(+) > create mode 100644 gdb/testsuite/gdb.mi/sym-file-lib.c > create mode 100644 gdb/testsuite/gdb.mi/sym-file-loader.c > create mode 100644 gdb/testsuite/gdb.mi/sym-file-loader.h > create mode 100644 gdb/testsuite/gdb.mi/sym-file-main.c >