Re: [PATCH v3] gdb tests: Allow for "LWP" in thread IDs from info threads.

[Pedro Alves <pedro@palves.net>]

On 2023-05-09 21:56, John Baldwin wrote:
> On 5/9/23 12:01 PM, Simon Marchi wrote:

>> And just one question:
>>
>>> diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp
>>> index 14db2511d40..a5b7ccf4ba5 100644
>>> --- a/gdb/testsuite/gdb.trace/report.exp
>>> +++ b/gdb/testsuite/gdb.trace/report.exp
>>> @@ -380,7 +380,7 @@ proc use_collected_data { data_source } {
>>>         # There is always a thread of an inferior, either a live one or
>>>       # a faked one.
>>> -    gdb_test "info threads" "\\* ${decimal}    (process|Thread) \[0-9\.\]+\[ \t\].*"
>>> +    gdb_test "info threads" "\\* ${decimal}    ${tdlabel_re} \[0-9\.\]+\[ \t\].*"
>>
>> This one said "process" as well, I guess it's not important?
> 
> Hummm, it didn't regress on Linux, 

FYI, the tracepoint tests only run when testing against gdbserver.

I definitely see FAILs if "process" isn't matched:

 $ make check RUNTESTFLAGS="--target_board=native-extended-gdbserver" TESTS="gdb.trace/report.exp"
 ...
 Running /home/pedro/gdb/src/gdb/testsuite/gdb.trace/report.exp ...
 FAIL: gdb.trace/report.exp: tfile: info threads
 FAIL: gdb.trace/report.exp: ctf: info threads