From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gHauGWy9Ama40BYAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 08:19:56 -0400 Received: by simark.ca (Postfix, from userid 112) id 64BA91E0C0; Tue, 26 Mar 2024 08:19:56 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 556B21E030 for ; Tue, 26 Mar 2024 08:19:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13F26385841F for ; Tue, 26 Mar 2024 12:19:54 +0000 (GMT) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id 4FFF93858C56 for ; Tue, 26 Mar 2024 12:19:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FFF93858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FFF93858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711455575; cv=none; b=JzTTluQFqDXr/9B3s0siAY4ciyNmeX9OG9S3dc2DwaR7FOuGW2W54H/UNORZw9BSdnAv7uIs6hVtMAuKXUluXd/n5xCd3eFHYMRHQ7JVwm3nYk2KFF8pCwaU2NVTxHVKDqIGalgw2tUCl27VhHQYt54yisYC13IpXFJGfukODEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711455575; c=relaxed/simple; bh=Q2RnEa1ehzb+/IZqeoSYvJyu1EetM4jSrNHAwdEEy+8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=M+dw81SukjoCD2ZuVi1VL2NehxMly7sqtcbCJv5+fe66PTzumSyzT7cSTZ71He3R1bDeOlFQIXg8YOhBOpnQ40aFgGUNww+SRMkgzaYVC0oPUtzvuEIdrwTZ/2ryJxj7u4WZRYcMg7+UoR/km4PmfDzg81uhK2LowyXRnH7SMEY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-41490d05bafso1455625e9.1 for ; Tue, 26 Mar 2024 05:19:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711455572; x=1712060372; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zze108m6vCbh5kzzhSbjKXxHZ9hPkz+dYIox9nTQEww=; b=kxd4zKO8AWwyzthwjppRpWWUyQvmXlu0824GQ+Rc90UZlGi7OFxasF8xEPdld4zgmQ UAWpSijvNmqegswUCDUQ4Kpjh8CE1XbwVhftX+423hDRDf2ypKmJbVmAxQvFZREz89Xk hBoOTuaJfpZ72MBZo50IxvtczGEMOx32zVDLhqucBYQNxLwvKooeeT6nxArcYUwoyQyh fDTO+tkBiFh7obKocCzLGs+Usv0Vivu12lpcXBsXZuAp8DtoEjAyP8ouWrVAD/jhbyKb 85xKtZiwZaRFmItrOnpem54ldE7k2D5L28MfG6qM9rVwuoE2B5oth3fzxpoF31Sd1a/S PsxQ== X-Forwarded-Encrypted: i=1; AJvYcCVc/hYGsXbGJae8PiPkzSmmB2OexUoCSvBasuH6PnPetTPBiasZDjErMHdYk6q20ysoyuquEfOAmUgcsREkeu5hh3+1WT3sbxJDlg== X-Gm-Message-State: AOJu0Yy8nnh9KRjZRl7tJxWv38KT6KOA4VEMSR/lDbEIJvSVHEM6MyDT q8P/RM2FVA5sAlM3ViNnZoHBSvZIR6c3GzjN0Fe0Q0RSRNqzD2/xW4PKr04Ci6E= X-Google-Smtp-Source: AGHT+IFLvmnPFLFfwLiJmASOJ5cf9eFvuQm57giMFa+1u5GrNR9LNBEbL43PV2MQ5d4xqbfxpvENiQ== X-Received: by 2002:adf:c681:0:b0:33d:73de:cd95 with SMTP id j1-20020adfc681000000b0033d73decd95mr8820991wrg.17.1711455572113; Tue, 26 Mar 2024 05:19:32 -0700 (PDT) Received: from ?IPV6:2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08? ([2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08]) by smtp.gmail.com with ESMTPSA id fl12-20020a05600c0b8c00b004148f9c5822sm1334980wmb.22.2024.03.26.05.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 05:19:31 -0700 (PDT) Message-ID: <076e4d7f-f6ca-4f4e-92e4-796dfdeaed19@palves.net> Date: Tue, 26 Mar 2024 12:19:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gdb tests: Allow for "LWP" in thread IDs from info threads. Content-Language: en-US To: John Baldwin , Simon Marchi , gdb-patches@sourceware.org References: <20230418201305.61272-1-jhb@FreeBSD.org> <10ba4b3e-19e0-2889-47de-67667db21af1@simark.ca> From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, BODY_8BITS, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2023-05-09 21:56, John Baldwin wrote: > On 5/9/23 12:01 PM, Simon Marchi wrote: >> And just one question: >> >>> diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp >>> index 14db2511d40..a5b7ccf4ba5 100644 >>> --- a/gdb/testsuite/gdb.trace/report.exp >>> +++ b/gdb/testsuite/gdb.trace/report.exp >>> @@ -380,7 +380,7 @@ proc use_collected_data { data_source } { >>>         # There is always a thread of an inferior, either a live one or >>>       # a faked one. >>> -    gdb_test "info threads" "\\* ${decimal}    (process|Thread) \[0-9\.\]+\[ \t\].*" >>> +    gdb_test "info threads" "\\* ${decimal}    ${tdlabel_re} \[0-9\.\]+\[ \t\].*" >> >> This one said "process" as well, I guess it's not important? > > Hummm, it didn't regress on Linux, FYI, the tracepoint tests only run when testing against gdbserver. I definitely see FAILs if "process" isn't matched: $ make check RUNTESTFLAGS="--target_board=native-extended-gdbserver" TESTS="gdb.trace/report.exp" ... Running /home/pedro/gdb/src/gdb/testsuite/gdb.trace/report.exp ... FAIL: gdb.trace/report.exp: tfile: info threads FAIL: gdb.trace/report.exp: ctf: info threads