From: "Kris Warkentin" <kewarken@qnx.com>
To: "Andrew Cagney" <ac131313@redhat.com>
Cc: "Gdb-Patches@Sources.Redhat.Com" <gdb-patches@sources.redhat.com>
Subject: Re: A.R. Index for GDB version 20030708
Date: Tue, 08 Jul 2003 19:38:00 -0000 [thread overview]
Message-ID: <05c801c34588$81096050$0202040a@catdog> (raw)
In-Reply-To: <3F0B1325.7060100@redhat.com>
diff -u -r1.4499 ChangeLog
--- ChangeLog 8 Jul 2003 15:36:44 -0000 1.4499
+++ ChangeLog 8 Jul 2003 19:36:52 -0000
@@ -1,6 +1,9 @@
2003-07-08 Kris Warkentin <kewarken@qnx.com>
* nto-procfs.c: Cleaned up a bunch of ARI hits.
+ Include "gdb_dirent.h" instead of <dirent.h>, replace all instances
+ of strerror with safe_strerror, use ISO C function definitions,
+ and replace instances of sprintf with snprintf.
cheers,
Kris
----- Original Message -----
From: "Andrew Cagney" <ac131313@redhat.com>
To: "Kris Warkentin" <kewarken@qnx.com>
Cc: "Gdb-Patches@Sources.Redhat.Com" <gdb-patches@sources.redhat.com>
Sent: Tuesday, July 08, 2003 2:53 PM
Subject: Re: A.R. Index for GDB version 20030708
> > 2003-07-08 Kris Warkentin <kewarken@qnx.com>
> >
> > * nto-procfs.c: Cleaned up a bunch of ARI hits.
> >
>
> Kris, don't forget, the change log should specify what was changed, not
> why. For instance:
>
> ...: Include "gdb_dirent.h" instead of <dirent.h", use strict ISO C,
> use safe_strerror. Clean up ARI hits.
>
> I'd tweak the changelog,
>
> Andrew
>
>
>
prev parent reply other threads:[~2003-07-08 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3F0AD10A.9000908@redhat.com>
2003-07-08 15:36 ` Kris Warkentin
2003-07-08 18:53 ` Andrew Cagney
2003-07-08 19:38 ` Kris Warkentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='05c801c34588$81096050$0202040a@catdog' \
--to=kewarken@qnx.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox