From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-25800-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1931 invoked by alias); 8 Jul 2003 19:38:00 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1924 invoked from network); 8 Jul 2003 19:37:59 -0000
Received: from unknown (HELO hub.ott.qnx.com) (209.226.137.76)
  by sources.redhat.com with SMTP; 8 Jul 2003 19:37:59 -0000
Received: from smtp.ott.qnx.com (smtp.ott.qnx.com [10.0.2.158])
	by hub.ott.qnx.com (8.9.3p2/8.9.3) with ESMTP id PAA27987;
	Tue, 8 Jul 2003 15:29:20 -0400
Received: from catdog ([10.4.2.2]) by smtp.ott.qnx.com (8.8.8/8.6.12) with SMTP id PAA06147; Tue, 8 Jul 2003 15:37:59 -0400
Message-ID: <05c801c34588$81096050$0202040a@catdog>
From: "Kris Warkentin" <kewarken@qnx.com>
To: "Andrew Cagney" <ac131313@redhat.com>
Cc: "Gdb-Patches@Sources.Redhat.Com" <gdb-patches@sources.redhat.com>
References: <3F0AD10A.9000908@redhat.com> <04e801c34566$c685e3f0$0202040a@catdog> <3F0B1325.7060100@redhat.com>
Subject: Re: A.R. Index for GDB version 20030708
Date: Tue, 08 Jul 2003 19:38:00 -0000
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
X-SW-Source: 2003-07/txt/msg00157.txt.bz2

diff -u -r1.4499 ChangeLog
--- ChangeLog   8 Jul 2003 15:36:44 -0000       1.4499
+++ ChangeLog   8 Jul 2003 19:36:52 -0000
@@ -1,6 +1,9 @@
 2003-07-08  Kris Warkentin  <kewarken@qnx.com>

        * nto-procfs.c: Cleaned up a bunch of ARI hits.
+       Include "gdb_dirent.h" instead of <dirent.h>, replace all instances
+       of strerror with safe_strerror, use ISO C function definitions,
+       and replace instances of sprintf with snprintf.

cheers,

Kris

----- Original Message ----- 
From: "Andrew Cagney" <ac131313@redhat.com>
To: "Kris Warkentin" <kewarken@qnx.com>
Cc: "Gdb-Patches@Sources.Redhat.Com" <gdb-patches@sources.redhat.com>
Sent: Tuesday, July 08, 2003 2:53 PM
Subject: Re: A.R. Index for GDB version 20030708


> > 2003-07-08  Kris Warkentin  <kewarken@qnx.com>
> > 
> >  * nto-procfs.c: Cleaned up a bunch of ARI hits.
> > 
> 
> Kris, don't forget, the change log should specify what was changed, not 
> why.  For instance:
> 
> ...: Include "gdb_dirent.h" instead of <dirent.h", use strict ISO C, 
> use safe_strerror.  Clean up ARI hits.
> 
> I'd tweak the changelog,
> 
> Andrew
> 
> 
>