Re: [PATCH] trad-frame cleanups

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-01-19 9:20 a.m., Luis Machado via Gdb-patches wrote:
> With the new member functions for struct trad_frame_saved_reg, there is no
> need to invoke some of the set/get functions anymore.  This patch removes
> those and adjusts all callers.
> 
> Even though the most natural initial state of a saved register value is
> UNKNOWN, there are target backends relying on the previous initial state
> of REALREG set to a register's own number. I noticed this in at least a
> couple targets: aarch64 and riscv.
> 
> Because of that, I decided to keep the reset function that sets the set of
> register values to REALREG. I can't exercise all the targets to make sure
> the initial state change won't break things, hence why it is risky to change
> the default.
> 
> Validated with --enable-targets=all on aarch64-linux Ubuntu 18.04/20.04.
> 
> Thoughts?

I did a spot check on a few files, and that LGTM, thanks!

Simon