From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /5RfE1f5BmC4PAAAWB0awg (envelope-from ) for ; Tue, 19 Jan 2021 10:23:03 -0500 Received: by simark.ca (Postfix, from userid 112) id 3DC1C1EF80; Tue, 19 Jan 2021 10:23:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7B3CF1E945 for ; Tue, 19 Jan 2021 10:23:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24FAE3850433; Tue, 19 Jan 2021 15:23:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24FAE3850433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611069782; bh=yxidSrkGXG990ZhtiGyGHzED60rON92L7fIEQ89LJIQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=hmpbRkuVXt1gHv2bFhiQHizPhwxpwO35Bl1zTHw50vwo8KsUaWMzSe1TvLCWMPJvj 0PrXGoZiQ8Oti6E+emUhFHQP8Mya7ZrTci3cFIoXGaPm2NPdTajtvDZDarZltVIr3P 2tY3gtbRZ51CS7+EKHFlwW/NPK6FpqaSbjwcUnJc= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 32231393C856 for ; Tue, 19 Jan 2021 15:23:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 32231393C856 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10JFMsbB019603 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Jan 2021 10:22:58 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10JFMsbB019603 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0F29D1E945; Tue, 19 Jan 2021 10:22:53 -0500 (EST) Subject: Re: [PATCH] trad-frame cleanups To: Luis Machado , gdb-patches@sourceware.org References: <20210119142014.1949161-1-luis.machado@linaro.org> Message-ID: <059e1efb-fc68-75ce-43ef-76ae4157d93c@polymtl.ca> Date: Tue, 19 Jan 2021 10:22:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210119142014.1949161-1-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 19 Jan 2021 15:22:54 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-19 9:20 a.m., Luis Machado via Gdb-patches wrote: > With the new member functions for struct trad_frame_saved_reg, there is no > need to invoke some of the set/get functions anymore. This patch removes > those and adjusts all callers. > > Even though the most natural initial state of a saved register value is > UNKNOWN, there are target backends relying on the previous initial state > of REALREG set to a register's own number. I noticed this in at least a > couple targets: aarch64 and riscv. > > Because of that, I decided to keep the reset function that sets the set of > register values to REALREG. I can't exercise all the targets to make sure > the initial state change won't break things, hence why it is risky to change > the default. > > Validated with --enable-targets=all on aarch64-linux Ubuntu 18.04/20.04. > > Thoughts? I did a spot check on a few files, and that LGTM, thanks! Simon