From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Wiederhake, Tim" <tim.wiederhake@intel.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org, "Metzger,
Markus T" <markus.t.metzger@intel.com>
Subject: Re: [PATCH] btrace: Store btrace_insn in an std::vector
Date: Mon, 04 Sep 2017 08:50:00 -0000 [thread overview]
Message-ID: <04914f7aff77a1f92be8403e74fa48ef@polymtl.ca> (raw)
In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF63631C0D@irsmsx105.ger.corp.intel.com>
On 2017-09-04 08:57, Wiederhake, Tim wrote:
> Hi Simon,
>
>> -----Original Message-----
>> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] On Behalf Of Simon Marchi
>> Sent: Sunday, September 3, 2017 11:06 AM
>> To: gdb-patches@sourceware.org
>> Cc: Metzger, Markus T <markus.t.metzger@intel.com>; Wiederhake, Tim
>> <tim.wiederhake@intel.com>; Simon Marchi <simon.marchi@ericsson.com>
>> Subject: [PATCH] btrace: Store btrace_insn in an std::vector
>>
>> Because it contains a non-POD type field (flags), the type btrace_insn
>> should be new'ed/delete'd. Replace the VEC (btrace_insn_s) in
>> btrace_function with an std::vector.
>>
>> gdb/ChangeLog:
>>
>> * btrace.h (btrace_insn_s, DEF_VEC_O (btrace_insn_s)): Remove.
>> (btrace_function) <insn>: Change type to use std::vector.
>> * btrace.c (ftrace_debug, ftrace_call_num_insn,
>> ftrace_find_call, ftrace_new_gap, ftrace_update_function,
>> ftrace_update_insns, ftrace_compute_global_level_offset,
>> btrace_stitch_bts, btrace_clear, btrace_insn_get,
>> btrace_insn_end, btrace_insn_next, btrace_insn_prev): Adjust to
>> change to std::vector.
>> (ftrace_update_insns): Adjust to change to std::vector, change
>> type of INSN parameter.
>> (btrace_compute_ftrace_bts): Adjust call to ftrace_update_insns.
>> * record-btrace.c (btrace_call_history_insn_range,
>> btrace_compute_src_line_range,
>> record_btrace_frame_prev_register): Adjust to change to
>> std::vector.
>> * python/py-record-btrace.c (recpy_bt_func_instructions): Adjust
>> to change to std::vector.
>
> Looks good to me -- but I don't have approval power.
That's fine, I can push it without a formal approval. I hoped one of
you two could look at it, since you know this code well. Thanks for
taking a look.
I just pushed it in.
Simon
prev parent reply other threads:[~2017-09-04 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 9:05 Simon Marchi
2017-09-04 6:57 ` Wiederhake, Tim
2017-09-04 8:50 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04914f7aff77a1f92be8403e74fa48ef@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=simon.marchi@ericsson.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox