From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107034 invoked by alias); 4 Sep 2017 08:50:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106158 invoked by uid 89); 4 Sep 2017 08:50:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Sep 2017 08:50:29 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v848oMak017484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 4 Sep 2017 04:50:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 67D5A1EA24; Mon, 4 Sep 2017 04:50:22 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 866671E974; Mon, 4 Sep 2017 04:50:01 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 04 Sep 2017 08:50:00 -0000 From: Simon Marchi To: "Wiederhake, Tim" Cc: Simon Marchi , gdb-patches@sourceware.org, "Metzger, Markus T" Subject: Re: [PATCH] btrace: Store btrace_insn in an std::vector In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF63631C0D@irsmsx105.ger.corp.intel.com> References: <1504429530-27720-1-git-send-email-simon.marchi@ericsson.com> <9676A094AF46E14E8265E7A3F4CCE9AF63631C0D@irsmsx105.ger.corp.intel.com> Message-ID: <04914f7aff77a1f92be8403e74fa48ef@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 4 Sep 2017 08:50:22 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00030.txt.bz2 On 2017-09-04 08:57, Wiederhake, Tim wrote: > Hi Simon, > >> -----Original Message----- >> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] On Behalf Of Simon Marchi >> Sent: Sunday, September 3, 2017 11:06 AM >> To: gdb-patches@sourceware.org >> Cc: Metzger, Markus T ; Wiederhake, Tim >> ; Simon Marchi >> Subject: [PATCH] btrace: Store btrace_insn in an std::vector >> >> Because it contains a non-POD type field (flags), the type btrace_insn >> should be new'ed/delete'd. Replace the VEC (btrace_insn_s) in >> btrace_function with an std::vector. >> >> gdb/ChangeLog: >> >> * btrace.h (btrace_insn_s, DEF_VEC_O (btrace_insn_s)): Remove. >> (btrace_function) : Change type to use std::vector. >> * btrace.c (ftrace_debug, ftrace_call_num_insn, >> ftrace_find_call, ftrace_new_gap, ftrace_update_function, >> ftrace_update_insns, ftrace_compute_global_level_offset, >> btrace_stitch_bts, btrace_clear, btrace_insn_get, >> btrace_insn_end, btrace_insn_next, btrace_insn_prev): Adjust to >> change to std::vector. >> (ftrace_update_insns): Adjust to change to std::vector, change >> type of INSN parameter. >> (btrace_compute_ftrace_bts): Adjust call to ftrace_update_insns. >> * record-btrace.c (btrace_call_history_insn_range, >> btrace_compute_src_line_range, >> record_btrace_frame_prev_register): Adjust to change to >> std::vector. >> * python/py-record-btrace.c (recpy_bt_func_instructions): Adjust >> to change to std::vector. > > Looks good to me -- but I don't have approval power. That's fine, I can push it without a formal approval. I hoped one of you two could look at it, since you know this code well. Thanks for taking a look. I just pushed it in. Simon