Set NetBSD xml syscall file name to syscalls/netbsd.xml

Set NetBSD xml syscall file name to syscalls/netbsd.xml

[Kamil Rytarowski]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

Hello,

Please review.

commit b69917f4975fc9b5edf54838c0119b35dbec9309
Author: Kamil Rytarowski <n54@gmx.com>
Date:   Wed Apr 29 15:33:33 2020 +0200

    Set NetBSD xml syscall file name to syscalls/netbsd.xml

    The syscall literal names are not stable on NetBSD and can change
    once a syscall is versioned. Thus these names are internal to the
    system and in GDB mostly descriptive, not intended to be a stable
    interface with fixed names across GDB and NetBSD versions to track
    certain syscalls.

    gdb/ChangeLog:

            * nbsd-tdep.c: Include "xml-syscall.h".
            (nbsd_init_abi): Call `set_xml_syscall_file_name'.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Set-NetBSD-xml-syscall-file-name-to-syscalls-netbsd..patch --]
[-- Type: text/x-patch, Size: 1806 bytes --]

From b69917f4975fc9b5edf54838c0119b35dbec9309 Mon Sep 17 00:00:00 2001
From: Kamil Rytarowski <n54@gmx.com>
Date: Wed, 29 Apr 2020 15:33:33 +0200
Subject: [PATCH] Set NetBSD xml syscall file name to syscalls/netbsd.xml

The syscall literal names are not stable on NetBSD and can change
once a syscall is versioned. Thus these names are internal to the
system and in GDB mostly descriptive, not intended to be a stable
interface with fixed names across GDB and NetBSD versions to track
certain syscalls.

gdb/ChangeLog:

	* nbsd-tdep.c: Include "xml-syscall.h".
	(nbsd_init_abi): Call `set_xml_syscall_file_name'.
---
 gdb/ChangeLog   | 5 +++++
 gdb/nbsd-tdep.c | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fb46a31b0a..7fe125c7c0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-04-29  Kamil Rytarowski  <n54@gmx.com>
+
+	* nbsd-tdep.c: Include "xml-syscall.h".
+	(nbsd_init_abi): Call `set_xml_syscall_file_name'.
+
 2020-04-28  Kamil Rytarowski  <n54@gmx.com>

 	* nbsd-nat.c: Include "sys/wait.h".
diff --git a/gdb/nbsd-tdep.c b/gdb/nbsd-tdep.c
index 2ed16f6faf..4fdfe476b5 100644
--- a/gdb/nbsd-tdep.c
+++ b/gdb/nbsd-tdep.c
@@ -25,6 +25,7 @@
 #include "nbsd-tdep.h"
 #include "gdbarch.h"
 #include "objfiles.h"
+#include "xml-syscall.h"

 /* Flags in the 'kve_protection' field in struct kinfo_vmentry.  These
    match the KVME_PROT_* constants in <sys/sysctl.h>.  */
@@ -470,5 +471,6 @@ nbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
   set_gdbarch_auxv_parse (gdbarch, svr4_auxv_parse);

   /* `catch syscall' */
+  set_xml_syscall_file_name (gdbarch, "syscalls/netbsd.xml");
   set_gdbarch_get_syscall_number (gdbarch, nbsd_get_syscall_number);
 }
--
2.25.2

Re: Set NetBSD xml syscall file name to syscalls/netbsd.xml

[Simon Marchi]

On 2020-04-29 8:44 a.m., Kamil Rytarowski wrote:
> Hello,
> 
> Please review.
> 
> commit b69917f4975fc9b5edf54838c0119b35dbec9309
> Author: Kamil Rytarowski <n54@gmx.com>
> Date:   Wed Apr 29 15:33:33 2020 +0200
> 
>     Set NetBSD xml syscall file name to syscalls/netbsd.xml
> 
>     The syscall literal names are not stable on NetBSD and can change
>     once a syscall is versioned. Thus these names are internal to the
>     system and in GDB mostly descriptive, not intended to be a stable
>     interface with fixed names across GDB and NetBSD versions to track
>     certain syscalls.
> 
>     gdb/ChangeLog:
> 
>             * nbsd-tdep.c: Include "xml-syscall.h".
>             (nbsd_init_abi): Call `set_xml_syscall_file_name'.
> 

Thanks, this is OK.

Simon