From: "Kris Warkentin" <kewarken@qnx.com>
To: "Mark Kettenis" <kettenis@chello.nl>
Cc: <gdb-patches@sources.redhat.com>
Subject: Re: [Patch 2] Native QNX Neutrino support
Date: Fri, 04 Jul 2003 15:55:00 -0000 [thread overview]
Message-ID: <01f201c34244$b75b5010$0202040a@catdog> (raw)
In-Reply-To: <200307041155.h64BtQtp009550@elgar.kettenis.dyndns.org>
> I finally found the time to review your "take 2".
Thanks Mark.
> * Use xstrdup() instead of strdup().
Done.
> * The function calls in the definitions of the QNX_NODE macro need
> spaces before the '(' just like in normal functions. Could you turn
> this macro into a function?
Turned the macro and function into one nto_node() function.
> * While what Andrew says about not having an XM_FILE is desirable, I
> think we still need xm-i386.h to have the best possible handling of
> floating-point numbers on a native GDB. If you don't set it,
> unnecessary conversions of floating-point numbers might occur,
> leading to loss of precision. I'll leave the decision to you.
While we don't need an xm-nto.h, it wouldn't seem to hurt to specify XM_FILE
as xm-i386.h. I'll do that.
> With those changes, please go ahead and check it in.
Done.
cheers,
Kris
prev parent reply other threads:[~2003-07-04 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-29 19:54 [Patch] " Kris Warkentin
2003-06-03 0:42 ` Michael Snyder
2003-06-03 11:05 ` Kris Warkentin
2003-06-05 12:26 ` Ping: " Kris Warkentin
2003-06-12 13:26 ` Ping " Kris Warkentin
2003-06-12 13:42 ` Daniel Jacobowitz
2003-06-15 12:33 ` Mark Kettenis
2003-06-15 16:09 ` Kris Warkentin
2003-06-15 16:19 ` Kris Warkentin
2003-06-16 17:36 ` [Patch 2] " Kris Warkentin
2003-06-16 20:43 ` Andrew Cagney
2003-07-04 11:56 ` Mark Kettenis
2003-07-04 15:55 ` Kris Warkentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01f201c34244$b75b5010$0202040a@catdog' \
--to=kewarken@qnx.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox