From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8236 invoked by alias); 4 Jul 2003 15:55:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8229 invoked from network); 4 Jul 2003 15:55:12 -0000 Received: from unknown (HELO hub.ott.qnx.com) (209.226.137.76) by sources.redhat.com with SMTP; 4 Jul 2003 15:55:12 -0000 Received: from smtp.ott.qnx.com (smtp.ott.qnx.com [10.0.2.158]) by hub.ott.qnx.com (8.9.3p2/8.9.3) with ESMTP id LAA21041; Fri, 4 Jul 2003 11:46:56 -0400 Received: from catdog ([10.4.2.2]) by smtp.ott.qnx.com (8.8.8/8.6.12) with SMTP id LAA22975; Fri, 4 Jul 2003 11:55:11 -0400 Message-ID: <01f201c34244$b75b5010$0202040a@catdog> From: "Kris Warkentin" To: "Mark Kettenis" Cc: References: <001a01c3261c$313284c0$0202040a@catdog> <86ptlfh67k.fsf@elgar.kettenis.dyndns.org> <06ad01c3342d$c4039e50$0202040a@catdog> <200307041155.h64BtQtp009550@elgar.kettenis.dyndns.org> Subject: Re: [Patch 2] Native QNX Neutrino support Date: Fri, 04 Jul 2003 15:55:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-07/txt/msg00103.txt.bz2 > I finally found the time to review your "take 2". Thanks Mark. > * Use xstrdup() instead of strdup(). Done. > * The function calls in the definitions of the QNX_NODE macro need > spaces before the '(' just like in normal functions. Could you turn > this macro into a function? Turned the macro and function into one nto_node() function. > * While what Andrew says about not having an XM_FILE is desirable, I > think we still need xm-i386.h to have the best possible handling of > floating-point numbers on a native GDB. If you don't set it, > unnecessary conversions of floating-point numbers might occur, > leading to loss of precision. I'll leave the decision to you. While we don't need an xm-nto.h, it wouldn't seem to hurt to specify XM_FILE as xm-i386.h. I'll do that. > With those changes, please go ahead and check it in. Done. cheers, Kris