From: "Eli Zaretskii" <eliz@gnu.org>
To: Orjan Friberg <orjan.friberg@axis.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit/cris] Add guru mode setting for CRISv32
Date: Fri, 13 May 2005 15:18:00 -0000 [thread overview]
Message-ID: <01c557bd$Blat.v2.4$cc59cd80@zahav.net.il> (raw)
In-Reply-To: <42849D2B.9030905@axis.com> (message from Orjan Friberg on Fri, 13 May 2005 14:27:23 +0200)
> Date: Fri, 13 May 2005 14:27:23 +0200
> From: Orjan Friberg <orjan.friberg@axis.com>
>
> Committed the following.
>
> 2005-05-13 Orjan Friberg <orjanf@axis.com>
>
> * cris-tdep.c (usr_cmd_cris_version): Change type to int.
> (cris_mode_normal, cris_mode_guru, cris_modes, usr_cmd_cris_mode): Add.
> (struct gdbarch_tdep): Change type of cris_version to int. Add
> cris_mode.
> (cris_mode, set_cris_mode): New functions.
> (crisv32_single_step_through_delay): Read from NRP register instead
> of ERP register in guru mode.
> (cris_breakpoint_from_pc): Rename break_insn to break8_insn.
> Add break15_insn, returned in guru mode.
> (_initialize_cris_tdep): Add call to add_setshow_enum_cmd for new
> cris-mode setting.
> (cris_dump_tdep): Add dump of cris_mode.
> (cris_gdbarch_init): Add cris_mode to search criteria for architecture.
> Register the sigtramp frame sniffer only if not in guru mode.
Thanks.
These patches introduced new user-level commands, but didn't include
any documentation for them, neither in the command's built-in
documentation nor in the manual. Please in the future _always_
accompany user-level changes with a suitable documentation changes.
Since the code is already in the CVS, I'm asking you to please post
documentation patches for these commands as soon as you can. There's
a "CRIS" subsection in the manual where the description should go.
Also, please improve the doc strings of the new setting you added:
they at least should list the possible settings for cris-mode.
TIA
next prev parent reply other threads:[~2005-05-13 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 13:18 Orjan Friberg
2005-05-13 15:18 ` Eli Zaretskii [this message]
2005-05-13 17:37 ` Orjan Friberg
2005-05-14 6:10 ` Eli Zaretskii
2005-05-13 17:42 ` Orjan Friberg
2005-05-14 7:13 ` Eli Zaretskii
2005-05-23 11:27 ` Orjan Friberg
2005-05-24 1:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c557bd$Blat.v2.4$cc59cd80@zahav.net.il' \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=orjan.friberg@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox