From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4234 invoked by alias); 13 May 2005 13:18:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4180 invoked from network); 13 May 2005 13:18:34 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 13 May 2005 13:18:34 -0000 Received: from zaretski (IGLD-83-130-254-105.inter.net.il [83.130.254.105]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id BFF00463 (AUTH halo1); Fri, 13 May 2005 16:18:07 +0300 (IDT) Date: Fri, 13 May 2005 15:18:00 -0000 From: "Eli Zaretskii" To: Orjan Friberg Message-ID: <01c557bd$Blat.v2.4$cc59cd80@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <42849D2B.9030905@axis.com> (message from Orjan Friberg on Fri, 13 May 2005 14:27:23 +0200) Subject: Re: [commit/cris] Add guru mode setting for CRISv32 Reply-to: Eli Zaretskii References: <42849D2B.9030905@axis.com> X-SW-Source: 2005-05/txt/msg00325.txt.bz2 > Date: Fri, 13 May 2005 14:27:23 +0200 > From: Orjan Friberg > > Committed the following. > > 2005-05-13 Orjan Friberg > > * cris-tdep.c (usr_cmd_cris_version): Change type to int. > (cris_mode_normal, cris_mode_guru, cris_modes, usr_cmd_cris_mode): Add. > (struct gdbarch_tdep): Change type of cris_version to int. Add > cris_mode. > (cris_mode, set_cris_mode): New functions. > (crisv32_single_step_through_delay): Read from NRP register instead > of ERP register in guru mode. > (cris_breakpoint_from_pc): Rename break_insn to break8_insn. > Add break15_insn, returned in guru mode. > (_initialize_cris_tdep): Add call to add_setshow_enum_cmd for new > cris-mode setting. > (cris_dump_tdep): Add dump of cris_mode. > (cris_gdbarch_init): Add cris_mode to search criteria for architecture. > Register the sigtramp frame sniffer only if not in guru mode. Thanks. These patches introduced new user-level commands, but didn't include any documentation for them, neither in the command's built-in documentation nor in the manual. Please in the future _always_ accompany user-level changes with a suitable documentation changes. Since the code is already in the CVS, I'm asking you to please post documentation patches for these commands as soon as you can. There's a "CRIS" subsection in the manual where the description should go. Also, please improve the doc strings of the new setting you added: they at least should list the possible settings for cris-mode. TIA