ylwrap

ylwrap

[Eli Zaretskii]

Who maintains ylwrap and where do I send patches for it?  It handles
DOS-style absolute file names in a way that is not 100% correct, so
I'd like to fix that.

TIA

Re: ylwrap

[Andreas Schwab]

"Eli Zaretskii" <eliz@gnu.org> writes:

> Who maintains ylwrap and where do I send patches for it?

# This file is maintained in Automake, please report
# bugs to <bug-automake@gnu.org> or send patches to
# <automake-patches@gnu.org>.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: ylwrap

[Daniel Jacobowitz]

On Wed, May 11, 2005 at 10:03:04PM +0200, Andreas Schwab wrote:
> "Eli Zaretskii" <eliz@gnu.org> writes:
> 
> > Who maintains ylwrap and where do I send patches for it?
> 
> # This file is maintained in Automake, please report
> # bugs to <bug-automake@gnu.org> or send patches to
> # <automake-patches@gnu.org>.

Note that our version is outdated anyway.  We can't import the new
version yet, because it's incompatible; it has to be done in sync with
two of the binutils directories which use Automake.

This has been on my TODO for a while but I haven't gotten any round
tuits lately.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: ylwrap

[Eli Zaretskii]

> Date: Wed, 11 May 2005 16:08:16 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
> 
> > # This file is maintained in Automake, please report
> > # bugs to <bug-automake@gnu.org> or send patches to
> > # <automake-patches@gnu.org>.
> 
> Note that our version is outdated anyway.  We can't import the new
> version yet, because it's incompatible; it has to be done in sync with
> two of the binutils directories which use Automake.
> 
> This has been on my TODO for a while but I haven't gotten any round
> tuits lately.

So what do I do for now? wait until we resync with the latest version,
or commit my changes in the GDB CVS?  Or maybe something else?

Re: ylwrap

[Daniel Jacobowitz]

On Thu, May 12, 2005 at 02:12:42AM +0300, Eli Zaretskii wrote:
> > Date: Wed, 11 May 2005 16:08:16 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
> > 
> > > # This file is maintained in Automake, please report
> > > # bugs to <bug-automake@gnu.org> or send patches to
> > > # <automake-patches@gnu.org>.
> > 
> > Note that our version is outdated anyway.  We can't import the new
> > version yet, because it's incompatible; it has to be done in sync with
> > two of the binutils directories which use Automake.
> > 
> > This has been on my TODO for a while but I haven't gotten any round
> > tuits lately.
> 
> So what do I do for now? wait until we resync with the latest version,
> or commit my changes in the GDB CVS?  Or maybe something else?

Hard to say in absence of the proposed changes.  The first thing to do
is make sure that the latest version in automake is OK, or fix it.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: ylwrap

[Eli Zaretskii]

> Date: Wed, 11 May 2005 19:32:54 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
> 
> > So what do I do for now? wait until we resync with the latest version,
> > or commit my changes in the GDB CVS?  Or maybe something else?
> 
> Hard to say in absence of the proposed changes.  The first thing to do
> is make sure that the latest version in automake is OK, or fix it.

The proposed patches are below; they fix the script's notion of
absolute file names on Windows/DOS.  The latest versions of the
script, both in the released Automake 1.9 and in Automake's CVS,
already include the equivalents of these patches.

Unless you (or someone else) are going to import the latest version of
ylwrap VSN, I'd like to commit these changes to the GDB repository,
since they should be harmless.

TIA


Index: ylwrap
===================================================================
RCS file: /cvs/src/src/ylwrap,v
retrieving revision 1.3
diff -u -r1.3 ylwrap
--- ylwrap	24 Sep 2004 13:21:46 -0000	1.3
+++ ylwrap	12 May 2005 12:57:36 -0000
@@ -31,15 +31,15 @@
 shift
 # Make any relative path in $prog absolute.
 case "$prog" in
- /* | [A-Za-z]:\\*) ;;
- */*) prog="`pwd`/$prog" ;;
+ [\\/]* | [A-Za-z]:[\\/]*) ;;
+ *[\\/]*) prog="`pwd`/$prog" ;;
 esac
 
 # The input.
 input="$1"
 shift
 case "$input" in
- /* | [A-Za-z]:\\*)
+ [\\/]* | [A-Za-z]:[\\/]*)
     # Absolute path; do nothing.
     ;;
  *)
@@ -52,7 +52,7 @@
 
 # We don't want to use the absolute path if the input in the current
 # directory like when making a tar ball.
-input_base=`echo $input | sed -e 's|.*/||'`
+input_base=`echo $input | sed -e 's|.*[\\/]||'`
 if test -f $input_base && cmp $input_base $input >/dev/null 2>&1; then
   input=$input_base
 fi
@@ -75,7 +75,7 @@
 
 cd $dirname
 case "$input" in
- /* | [A-Za-z]:\\*)
+ [\\/]* | [A-Za-z]:[\\/]*)
     # Absolute path; do nothing.
     ;;
  *)
@@ -95,7 +95,7 @@
          # If $2 is an absolute path name, then just use that,
          # otherwise prepend `../'.
          case "$2" in
-	   /* | [A-Za-z]:\\*) target="$2";;
+	   [\\/]* | [A-Za-z]:[\\/]*) target="$2";;
 	   *) target="../$2";;
 	 esac
 	 mv "$1" "$target" || status=$?

Re: ylwrap

[Daniel Jacobowitz]

On Thu, May 12, 2005 at 03:59:08PM +0300, Eli Zaretskii wrote:
> > Date: Wed, 11 May 2005 19:32:54 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: gdb-patches@sourceware.org
> > 
> > > So what do I do for now? wait until we resync with the latest version,
> > > or commit my changes in the GDB CVS?  Or maybe something else?
> > 
> > Hard to say in absence of the proposed changes.  The first thing to do
> > is make sure that the latest version in automake is OK, or fix it.
> 
> The proposed patches are below; they fix the script's notion of
> absolute file names on Windows/DOS.  The latest versions of the
> script, both in the released Automake 1.9 and in Automake's CVS,
> already include the equivalents of these patches.
> 
> Unless you (or someone else) are going to import the latest version of
> ylwrap VSN, I'd like to commit these changes to the GDB repository,
> since they should be harmless.
> 
> TIA

Thanks for the patch, Eli.

I am going to _try_ to do the import today.  If it turns out that I
don't get it done, then I think the patch is fine; but be sure to check
with DJ Delorie first to sync with the GCC repository (see MAINTAINERS
in the top level).


-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: ylwrap

[Eli Zaretskii]

> From: Andreas Schwab <schwab@suse.de>
> Cc: gdb-patches@sourceware.org
> Date: Wed, 11 May 2005 22:03:04 +0200
> 
> "Eli Zaretskii" <eliz@gnu.org> writes:
> 
> > Who maintains ylwrap and where do I send patches for it?
> 
> # This file is maintained in Automake, please report
> # bugs to <bug-automake@gnu.org> or send patches to
> # <automake-patches@gnu.org>.

Thanks.  I don't see this passage in the version of ylwrap we have in
the GDB repository.  I guess you were looking at a newer version.