From: "Eli Zaretskii" <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Re: [commit] Ignore SEGVs from win32 IsBad* functions
Date: Sun, 27 Mar 2005 19:31:00 -0000 [thread overview]
Message-ID: <01c53303$Blat.v2.4$4e007b20@zahav.net.il> (raw)
In-Reply-To: <20050327154340.GA22694@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 27 Mar 2005 10:43:40 -0500)
> Date: Sun, 27 Mar 2005 10:43:40 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
>
> > Nitpicking: won't it be cleaner to have a single string
> > "KERNEL32!IsBad", instead of mentioning it twice, and to use sizeof
> > instead of strlen?
>
> The only thing this saves you is the chance of typos; recent GCC
> versions will not only combine the strings, but also fold strlen to a
> constant.
I know about these GCC features, but IMHO the code still looks cleaner
with the changes I suggested, and typos are not something we should
take too lightly.
(I did say I was nitpicking ;-)
prev parent reply other threads:[~2005-03-27 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-27 5:21 Christopher Faylor
2005-03-27 10:56 ` Eli Zaretskii
2005-03-27 15:42 ` Daniel Jacobowitz
2005-03-27 19:31 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c53303$Blat.v2.4$4e007b20@zahav.net.il' \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox