From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22631 invoked by alias); 27 Mar 2005 19:31:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22605 invoked from network); 27 Mar 2005 19:31:47 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 27 Mar 2005 19:31:47 -0000 Received: from zaretski (IGLD-83-130-253-83.inter.net.il [83.130.253.83]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id AVQ72191 (AUTH halo1); Sun, 27 Mar 2005 21:31:45 +0200 (IST) Date: Sun, 27 Mar 2005 19:31:00 -0000 From: "Eli Zaretskii" To: gdb-patches@sourceware.org Message-ID: <01c53303$Blat.v2.4$4e007b20@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 In-reply-to: <20050327154340.GA22694@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 27 Mar 2005 10:43:40 -0500) Subject: Re: [commit] Ignore SEGVs from win32 IsBad* functions Reply-to: Eli Zaretskii References: <20050327052052.GA23610@coe.casa.cgf.cx> <01c532bb$Blat.v2.4$589bb600@zahav.net.il> <20050327154340.GA22694@nevyn.them.org> X-SW-Source: 2005-03/txt/msg00363.txt.bz2 > Date: Sun, 27 Mar 2005 10:43:40 -0500 > From: Daniel Jacobowitz > Cc: gdb-patches@sourceware.org > > > Nitpicking: won't it be cleaner to have a single string > > "KERNEL32!IsBad", instead of mentioning it twice, and to use sizeof > > instead of strlen? > > The only thing this saves you is the chance of typos; recent GCC > versions will not only combine the strings, but also fold strlen to a > constant. I know about these GCC features, but IMHO the code still looks cleaner with the changes I suggested, and typos are not something we should take too lightly. (I did say I was nitpicking ;-)