Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@gnu.org>
To: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
Cc: gdb-patches@sources.redhat.com
Subject: Re: i18n, part 3
Date: Thu, 20 Jan 2005 21:14:00 -0000	[thread overview]
Message-ID: <01c4ff34$Blat.v2.4$9e7d2380@zahav.net.il> (raw)
In-Reply-To: <20050119222228.GA17540@radix50.net> (message from Baurjan Ismagulov on Wed, 19 Jan 2005 22:22:33 +0000)

> Date: Wed, 19 Jan 2005 22:22:33 +0000
> From: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
> 
> here is the next chunk.

Thanks!

> Comments?

Below.

> Is the following declaration near the end of ax-gdb.c unnecessary?
> 
> void _initialize_ax_gdb (void);

No, it isn't unnecessary (under certain command-line options, GCC will
whine if it sees a function definition without a prototype anywhere in
scope).

> -      error ("Illegal type cast: intended type must be scalar.");
> +      error (_("Illegal type cast: intended type must be scalar."));

Please change "Illegal" into "Invalid" (here and everywhere else in
your patches).

> -    error_no_arg ("pcb address");
> +    error_no_arg (_("pcb address"));

Should we have an i18n comment here explaining what's a pcb?  (You did
that elsewhere in the patch.)

>    add_cmd ("pcb", class_obscure, bsd_kvm_pcb_cmd,
> -	   "Set current context from pcb address", &bsd_kvm_cmdlist);
> +	   _("Set current context from pcb address"), &bsd_kvm_cmdlist);

Here also.


  reply	other threads:[~2005-01-20 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-19 22:25 Baurjan Ismagulov
2005-01-20 21:14 ` Eli Zaretskii [this message]
2005-01-29 15:50   ` Baurzhan Ismagulov
2005-01-29 17:22     ` Eli Zaretskii
2005-01-29 17:55       ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01c4ff34$Blat.v2.4$9e7d2380@zahav.net.il' \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ibr@ata.cs.hun.edu.tr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox