From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-37840-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 24654 invoked by alias); 20 Jan 2005 21:14:26 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24608 invoked from network); 20 Jan 2005 21:14:18 -0000
Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24)
  by sourceware.org with SMTP; 20 Jan 2005 21:14:18 -0000
Received: from zaretski (tony02-22-136.inter.net.il [80.230.22.136])
	by legolas.inter.net.il (MOS 3.5.6-GR)
	with ESMTP id DOQ06311 (AUTH halo1);
	Thu, 20 Jan 2005 23:14:07 +0200 (IST)
Date: Thu, 20 Jan 2005 21:14:00 -0000
From: "Eli Zaretskii" <eliz@gnu.org>
To: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
Message-ID: <01c4ff34$Blat.v2.4$9e7d2380@zahav.net.il>
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=ISO-8859-1
CC: gdb-patches@sources.redhat.com
In-reply-to: <20050119222228.GA17540@radix50.net> (message from Baurjan
	Ismagulov on Wed, 19 Jan 2005 22:22:33 +0000)
Subject: Re: i18n, part 3
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <20050119222228.GA17540@radix50.net>
X-SW-Source: 2005-01/txt/msg00221.txt.bz2

> Date: Wed, 19 Jan 2005 22:22:33 +0000
> From: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
> 
> here is the next chunk.

Thanks!

> Comments?

Below.

> Is the following declaration near the end of ax-gdb.c unnecessary?
> 
> void _initialize_ax_gdb (void);

No, it isn't unnecessary (under certain command-line options, GCC will
whine if it sees a function definition without a prototype anywhere in
scope).

> -      error ("Illegal type cast: intended type must be scalar.");
> +      error (_("Illegal type cast: intended type must be scalar."));

Please change "Illegal" into "Invalid" (here and everywhere else in
your patches).

> -    error_no_arg ("pcb address");
> +    error_no_arg (_("pcb address"));

Should we have an i18n comment here explaining what's a pcb?  (You did
that elsewhere in the patch.)

>    add_cmd ("pcb", class_obscure, bsd_kvm_pcb_cmd,
> -	   "Set current context from pcb address", &bsd_kvm_cmdlist);
> +	   _("Set current context from pcb address"), &bsd_kvm_cmdlist);

Here also.