* [RFA/testcase] Enable overlays.exp only for sim target
@ 2004-10-01 9:10 Kei Sakamoto
2004-10-01 21:31 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Kei Sakamoto @ 2004-10-01 9:10 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
Hello,
The attached patch ensables overlays.exp test only for sim target.
Because overlay function does not work for other targets.
OK to commit?
2004-10-01 Kei Sakamoto <sakamoto.kei@renesas.com>
* gdb.base/overlays.exp: Enable only for sim target.
[-- Attachment #2: overlays.patch --]
[-- Type: application/octet-stream, Size: 727 bytes --]
Index: gdb.base/overlays.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/overlays.exp,v
retrieving revision 1.5
diff -u -r1.5 overlays.exp
--- gdb.base/overlays.exp 20 Jan 2003 15:40:07 -0000 1.5
+++ gdb.base/overlays.exp 1 Oct 2004 08:41:38 -0000
@@ -30,7 +30,10 @@
set prms_id 0
set bug_id 0
-if [istarget "d10v-*-*"] then {
+if { [istarget info protocol] != "sim" } {
+ verbose "Skipping overlay test -- only available for sim."
+ return
+} elseif [istarget "d10v-*-*"] then {
set linker_script "${srcdir}/${subdir}/d10v.ld";
} elseif [istarget "m32r-*-*"] then {
set linker_script "${srcdir}/${subdir}/m32r.ld";
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/testcase] Enable overlays.exp only for sim target
2004-10-01 9:10 [RFA/testcase] Enable overlays.exp only for sim target Kei Sakamoto
@ 2004-10-01 21:31 ` Michael Snyder
2004-10-05 4:52 ` Kei Sakamoto
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2004-10-01 21:31 UTC (permalink / raw)
To: Kei Sakamoto; +Cc: gdb-patches
Kei Sakamoto wrote:
> Hello,
>
> The attached patch ensables overlays.exp test only for sim target.
> Because overlay function does not work for other targets.
>
> OK to commit?
>
> 2004-10-01 Kei Sakamoto <sakamoto.kei@renesas.com>
>
> * gdb.base/overlays.exp: Enable only for sim target.
Kei,
I guess I've never run this test on d10v hardware, but
I used to run it on m32r hardware. Why would it only
work on the sim?
Matter of fact, why shouldn't it work just about anywhere?
It doesn't have any hardware dependency, just a linker script.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA/testcase] Enable overlays.exp only for sim target
2004-10-01 21:31 ` Michael Snyder
@ 2004-10-05 4:52 ` Kei Sakamoto
2004-10-07 18:26 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Kei Sakamoto @ 2004-10-05 4:52 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
> I guess I've never run this test on d10v hardware, but
> I used to run it on m32r hardware. Why would it only
> work on the sim?
I'm sorry. I forgot about the remote debug environment.
The overlay test should work on evaluation boards and
emulators too.
> Matter of fact, why shouldn't it work just about anywhere?
> It doesn't have any hardware dependency, just a linker script.
It seems that Linux kernel can't load overlaid programs
into memory because VMA and LMA of overlaid
sections are different. So overlays.exp is not available on
the Linux.
I revised the patch file. It disables overlays.exp if target is Linux.
Is this OK?
Kei Sakamoto
2004-10-05 Kei Sakamoto <sakamoto.kei@renesas.com>
* gdb.base/overlays.exp: Disables if target is Linux.
[-- Attachment #2: overlays.patch --]
[-- Type: application/octet-stream, Size: 606 bytes --]
Index: gdb.base/overlays.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/overlays.exp,v
retrieving revision 1.5
diff -u -r1.5 overlays.exp
--- gdb.base/overlays.exp 20 Jan 2003 15:40:07 -0000 1.5
+++ gdb.base/overlays.exp 5 Oct 2004 04:39:51 -0000
@@ -39,6 +39,11 @@
return
}
+if [istarget "*-*-linux*"] then {
+ verbose "Skipping overlay test -- Linux doesn't support overlayed programs."
+ return
+}
+
set testfile "overlays"
set binfile ${objdir}/${subdir}/${testfile}
set srcfile ${testfile}.c
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/testcase] Enable overlays.exp only for sim target
2004-10-05 4:52 ` Kei Sakamoto
@ 2004-10-07 18:26 ` Michael Snyder
2004-10-08 1:03 ` Kei Sakamoto
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2004-10-07 18:26 UTC (permalink / raw)
To: Kei Sakamoto; +Cc: gdb-patches
Kei Sakamoto wrote:
>>I guess I've never run this test on d10v hardware, but
>>I used to run it on m32r hardware. Why would it only
>>work on the sim?
>
>
>
> I'm sorry. I forgot about the remote debug environment.
> The overlay test should work on evaluation boards and
> emulators too.
>
>
>>Matter of fact, why shouldn't it work just about anywhere?
>>It doesn't have any hardware dependency, just a linker script.
>
>
> It seems that Linux kernel can't load overlaid programs
> into memory because VMA and LMA of overlaid
> sections are different. So overlays.exp is not available on
> the Linux.
>
> I revised the patch file. It disables overlays.exp if target is Linux.
>
> Is this OK?
Yes, this is great -- thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA/testcase] Enable overlays.exp only for sim target
2004-10-07 18:26 ` Michael Snyder
@ 2004-10-08 1:03 ` Kei Sakamoto
2004-10-08 18:13 ` Michael Chastain
0 siblings, 1 reply; 6+ messages in thread
From: Kei Sakamoto @ 2004-10-08 1:03 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
I've committed the following patch. Thank you.
Kei Sakamoto
Michael Snyder wrote:
> Kei Sakamoto wrote:
> >>I guess I've never run this test on d10v hardware, but
> >>I used to run it on m32r hardware. Why would it only
> >>work on the sim?
> >
> > I'm sorry. I forgot about the remote debug environment.
> > The overlay test should work on evaluation boards and
> > emulators too.
> >
> >>Matter of fact, why shouldn't it work just about anywhere?
> >>It doesn't have any hardware dependency, just a linker script.
> >
> > It seems that Linux kernel can't load overlaid programs
> > into memory because VMA and LMA of overlaid
> > sections are different. So overlays.exp is not available on
> > the Linux.
> >
> > I revised the patch file. It disables overlays.exp if target is Linux.
> >
> > Is this OK?
>
> Yes, this is great -- thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-10-08 18:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-01 9:10 [RFA/testcase] Enable overlays.exp only for sim target Kei Sakamoto
2004-10-01 21:31 ` Michael Snyder
2004-10-05 4:52 ` Kei Sakamoto
2004-10-07 18:26 ` Michael Snyder
2004-10-08 1:03 ` Kei Sakamoto
2004-10-08 18:13 ` Michael Chastain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox