From: Simon Marchi <simon.marchi@polymtl.ca>
To: Jan Vrany <jan.vrany@fit.cvut.cz>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix various tests to use -no-pie linker flag when needed
Date: Tue, 16 Oct 2018 22:18:00 -0000 [thread overview]
Message-ID: <01b5605a3df81c4d773a82e8648051fa@polymtl.ca> (raw)
In-Reply-To: <9dbaccd25aae8bdf1cd96e59ae8f7c9be9cce7db.camel@fit.cvut.cz>
On 2018-10-14 05:59, Jan Vrany wrote:
> Hi,
>
> I'm sorry for a long delay, I've been very, very busy lately.
> Hopefully I'd have more time for GDB now...
>
>
> On Fri, 2018-09-07 at 23:18 +0100, Simon Marchi wrote:
>> On 2018-09-07 21:43, Tom Tromey wrote:
>> > > > > > > "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:
>> >
>> > Jan> Various test use test code written in i385 / x86_64 assembly that
>> > cannot
>> > Jan> be used to create PIE executables. Therefore compilation of test
>> > programs
>> > Jan> failed on systems where the compiler default is to create PIE
>> > executable.
>> >
>> > Jan> To fix this, force -no-pie linker flag.
>> >
>> > I guess you're on an OS that enables PIE by default?
>>
>> I know recent-ish Ubuntus do that, I don't know if it's a patch
>> specific
>> to that distro or if it's the default value in gcc that changed.
>
> Neither I know. I'm using Debian Buster which seems to have -no-pie
> by default too.
>
>>
>> > These tests don't seem to be linux- or gcc-specific.
>> > Do you know how universal -no-pie is? My worry is that this would fix
>> > the test for some people but break it for others.
>> >
>
> No, I don't know how universal -no-pie is. From what I have understood
> from Simon
> (https://sourceware.org/ml/gdb-patches/2018-08/msg00662.html),
> out of the options available -no-pie is still the best bet.
gcc supports it, icc supports it [1], clang supports it starting at
version 6 according to my testing. I think this is universal enough
that we can use it. If somebody stumbles on a compiler that does not
understand -no-pie and they really need to use it for their testing,
they can quite easily add an option for gdb_compile. But for now, I
don't think it's worth the extra work.
[1] https://software.intel.com/en-us/node/523278
I tested the patch and amd64-disp-step.exp fails for me. When you
specify options to prepare_for_testing explicitly, you have to include
the "debug" option (if you do want debug symbols).
With this fix the patch LGTM.
Simon
next prev parent reply other threads:[~2018-10-16 22:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 19:37 Jan Vrany
2018-09-07 20:43 ` Tom Tromey
2018-09-07 22:18 ` Simon Marchi
2018-10-14 9:59 ` Jan Vrany
2018-10-16 22:18 ` Simon Marchi [this message]
2018-10-17 13:55 ` Tom Tromey
2018-10-17 14:56 ` [PATCH v2] " Jan Vrany
2018-10-17 15:12 ` [PATCH v3] " Jan Vrany
2018-10-17 15:44 ` Simon Marchi
2018-10-17 15:53 ` Simon Marchi
2018-10-17 19:33 ` Jan Vrany
2018-12-13 15:21 ` [PATCH] " Jan Vrany
2018-12-13 17:13 ` Simon Marchi
2018-12-21 20:56 ` Simon Marchi
2018-10-17 15:47 ` Pedro Alves
2018-10-17 15:51 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01b5605a3df81c4d773a82e8648051fa@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@fit.cvut.cz \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox