From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86794 invoked by alias); 16 Oct 2018 22:18:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86782 invoked by uid 89); 16 Oct 2018 22:18:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_20,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=lately, Debian, H*f:sk:9dbaccd, nopie X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Oct 2018 22:18:32 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9GMIOKY030781 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Oct 2018 18:18:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 883B81EA70; Tue, 16 Oct 2018 18:18:24 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 82CDE1E519; Tue, 16 Oct 2018 18:18:22 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 16 Oct 2018 22:18:00 -0000 From: Simon Marchi To: Jan Vrany Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix various tests to use -no-pie linker flag when needed In-Reply-To: <9dbaccd25aae8bdf1cd96e59ae8f7c9be9cce7db.camel@fit.cvut.cz> References: <20180828193643.15530-1-jan.vrany@fit.cvut.cz> <87lg8dvy0o.fsf@tromey.com> <9dbaccd25aae8bdf1cd96e59ae8f7c9be9cce7db.camel@fit.cvut.cz> Message-ID: <01b5605a3df81c4d773a82e8648051fa@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00358.txt.bz2 On 2018-10-14 05:59, Jan Vrany wrote: > Hi, > > I'm sorry for a long delay, I've been very, very busy lately. > Hopefully I'd have more time for GDB now... > > > On Fri, 2018-09-07 at 23:18 +0100, Simon Marchi wrote: >> On 2018-09-07 21:43, Tom Tromey wrote: >> > > > > > > "Jan" == Jan Vrany writes: >> > >> > Jan> Various test use test code written in i385 / x86_64 assembly that >> > cannot >> > Jan> be used to create PIE executables. Therefore compilation of test >> > programs >> > Jan> failed on systems where the compiler default is to create PIE >> > executable. >> > >> > Jan> To fix this, force -no-pie linker flag. >> > >> > I guess you're on an OS that enables PIE by default? >> >> I know recent-ish Ubuntus do that, I don't know if it's a patch >> specific >> to that distro or if it's the default value in gcc that changed. > > Neither I know. I'm using Debian Buster which seems to have -no-pie > by default too. > >> >> > These tests don't seem to be linux- or gcc-specific. >> > Do you know how universal -no-pie is? My worry is that this would fix >> > the test for some people but break it for others. >> > > > No, I don't know how universal -no-pie is. From what I have understood > from Simon > (https://sourceware.org/ml/gdb-patches/2018-08/msg00662.html), > out of the options available -no-pie is still the best bet. gcc supports it, icc supports it [1], clang supports it starting at version 6 according to my testing. I think this is universal enough that we can use it. If somebody stumbles on a compiler that does not understand -no-pie and they really need to use it for their testing, they can quite easily add an option for gdb_compile. But for now, I don't think it's worth the extra work. [1] https://software.intel.com/en-us/node/523278 I tested the patch and amd64-disp-step.exp fails for me. When you specify options to prepare_for_testing explicitly, you have to include the "debug" option (if you do want debug symbols). With this fix the patch LGTM. Simon