Re: patch to allow target defined solib search method

["Kris Warkentin" <kewarken@qnx.com>]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

Here.  Now they are unix text files attached with proper formatting.  I also
put myself in the Write After section instead of the maintainers.

Thanks.

Kris

----- Original Message -----
From: "Daniel Jacobowitz" <drow@mvista.com>
To: <gdb-patches@sources.redhat.com>
Sent: Saturday, February 22, 2003 1:14 AM
Subject: Re: patch to allow target defined solib search method


> On Fri, Feb 21, 2003 at 11:36:15PM -0500, Kris Warkentin wrote:
> > Here you go.  I chopped up the long lines and used your formatting for
the
> > ChangeLog.  I also added myself to MAINTAINERS at the bottom of the
patch.
> > Makes sense since I'm the gdb guy at QNX now.  Sorry about the missing
tabs
> > in the ChangeLog.  Outlook doesn't DO tabs...I guess Microsoft doesn't
> > believe in them. :-P  Would it be better if I just attached text files
next
> > time?
>
> Please do attach files, if you're forced to use outlook.  If you can
> use something else, even better.
>
> Meanwhile, Kevin suggested that you add yourself under Write After
> Approval, not as a target maintainer - you'll probably get stuck with
> that too, but it should wait until the target is being committed.
>
> --
> Daniel Jacobowitz
> MontaVista Software                         Debian GNU/Linux Developer
>

[-- Attachment #2: solib.diff --]
[-- Type: application/octet-stream, Size: 2401 bytes --]

Index: solib.c
===================================================================
RCS file: /cvs/src/src/gdb/solib.c,v
retrieving revision 1.54
diff -u -r1.54 solib.c
--- solib.c	20 Feb 2003 18:25:27 -0000	1.54
+++ solib.c	24 Feb 2003 16:03:28 -0000
@@ -160,6 +160,11 @@
                         1, lbasename (in_pathname), O_RDONLY, 0,
                         &temp_pathname);
 
+  /* If not found, try to use target supplied solib search method */
+  if (found_file < 0 && TARGET_SO_FIND_AND_OPEN_SOLIB != NULL)
+    found_file = TARGET_SO_FIND_AND_OPEN_SOLIB
+                 (in_pathname, O_RDONLY, &temp_pathname);
+
   /* If not found, next search the inferior's $PATH environment variable. */
   if (found_file < 0 && solib_search_path != NULL)
     found_file = openp (get_in_environ (inferior_environ, "PATH"),
Index: solist.h
===================================================================
RCS file: /cvs/src/src/gdb/solist.h,v
retrieving revision 1.7
diff -u -r1.7 solist.h
--- solist.h	21 Oct 2001 19:20:30 -0000	1.7
+++ solist.h	24 Feb 2003 16:03:28 -0000
@@ -99,6 +99,12 @@
     /* Determine if PC lies in the dynamic symbol resolution code of
        the run time loader */
     int (*in_dynsym_resolve_code) (CORE_ADDR pc);
+
+    /* Extra hook for finding and opening a solib.  Convenience function
+       for remote debuggers finding host libs */
+    int (*find_and_open_solib) (char *soname,
+        unsigned o_flags, char **temp_pathname);
+    
   };
 
 void free_so (struct so_list *so);
@@ -122,5 +128,7 @@
   (current_target_so_ops->open_symbol_file_object)
 #define TARGET_SO_IN_DYNSYM_RESOLVE_CODE \
   (current_target_so_ops->in_dynsym_resolve_code)
+#define TARGET_SO_FIND_AND_OPEN_SOLIB \
+  (current_target_so_ops->find_and_open_solib)
 
 #endif
Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.224
diff -u -r1.224 MAINTAINERS
--- MAINTAINERS	22 Feb 2003 00:24:11 -0000	1.224
+++ MAINTAINERS	24 Feb 2003 16:03:28 -0000
@@ -391,6 +391,7 @@
 Tom Tromey					tromey@redhat.com
 Corinna Vinschen				vinschen@redhat.com
 Keith Walker					keith.walker@arm.com
+Kris Warkentin					kewarken@qnx.com
 Jim Wilson					wilson@tuliptree.org
 Elena Zannoni					ezannoni@redhat.com
 Eli Zaretskii					eliz@gnu.org

[-- Attachment #3: solib.changelog --]
[-- Type: application/octet-stream, Size: 260 bytes --]

2003-02-24  Kris Warkentin  <kewarken@qnx.com>
	* solib.c (solib_open): Call target specific search function after
	failing with solib-search-path.
	* solist.h (struct target_so_ops): Add find_and_open_solib().
	(TARGET_SO_FIND_AND_OPEN_SOLIB): Define.