From: "Kris Warkentin" <kewarken@qnx.com>
To: "Kevin Buettner" <kevinb@redhat.com>, <gdb-patches@sources.redhat.com>
Subject: Re: patch to allow target defined solib search method
Date: Sat, 22 Feb 2003 04:33:00 -0000 [thread overview]
Message-ID: <004501c2da2b$efdb49d0$2a00a8c0@dash> (raw)
In-Reply-To: <1030222020400.ZM18826@localhost.localdomain>
Here you go. I chopped up the long lines and used your formatting for the
ChangeLog. I also added myself to MAINTAINERS at the bottom of the patch.
Makes sense since I'm the gdb guy at QNX now. Sorry about the missing tabs
in the ChangeLog. Outlook doesn't DO tabs...I guess Microsoft doesn't
believe in them. :-P Would it be better if I just attached text files next
time?
cheers,
Kris
ChangeLog Entry
* solib.c (solib_open): Call target specific search function after
failing with solib-search-path.
* solist.h (struct target_so_ops): Add find_and_open_solib().
(TARGET_SO_FIND_AND_OPEN_SOLIB): Define.
Index: solib.c
===================================================================
RCS file: /cvs/src/src/gdb/solib.c,v
retrieving revision 1.54
diff -u -r1.54 solib.c
--- solib.c 20 Feb 2003 18:25:27 -0000 1.54
+++ solib.c 22 Feb 2003 04:21:45 -0000
@@ -160,6 +160,11 @@
1, lbasename (in_pathname), O_RDONLY, 0,
&temp_pathname);
+ /* If not found, try to use target supplied solib search method */
+ if (found_file < 0 && TARGET_SO_FIND_AND_OPEN_SOLIB != NULL)
+ found_file = TARGET_SO_FIND_AND_OPEN_SOLIB
+ (in_pathname, O_RDONLY, &temp_pathname);
+
/* If not found, next search the inferior's $PATH environment variable.
*/
if (found_file < 0 && solib_search_path != NULL)
found_file = openp (get_in_environ (inferior_environ, "PATH"),
Index: solist.h
===================================================================
RCS file: /cvs/src/src/gdb/solist.h,v
retrieving revision 1.7
diff -u -r1.7 solist.h
--- solist.h 21 Oct 2001 19:20:30 -0000 1.7
+++ solist.h 22 Feb 2003 04:21:45 -0000
@@ -99,6 +99,12 @@
/* Determine if PC lies in the dynamic symbol resolution code of
the run time loader */
int (*in_dynsym_resolve_code) (CORE_ADDR pc);
+
+ /* Extra hook for finding and opening a solib. Convenience function
+ for remote debuggers finding host libs */
+ int (*find_and_open_solib) (char *soname,
+ unsigned o_flags, char **temp_pathname);
+
};
void free_so (struct so_list *so);
@@ -122,5 +128,7 @@
(current_target_so_ops->open_symbol_file_object)
#define TARGET_SO_IN_DYNSYM_RESOLVE_CODE \
(current_target_so_ops->in_dynsym_resolve_code)
+#define TARGET_SO_FIND_AND_OPEN_SOLIB \
+ (current_target_so_ops->find_and_open_solib)
#endif
Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.223
diff -u -r1.223 MAINTAINERS
--- MAINTAINERS 4 Feb 2003 23:26:43 -0000 1.223
+++ MAINTAINERS 22 Feb 2003 04:21:45 -0000
@@ -200,6 +200,8 @@
Peter Schauer Peter.Schauer@regent.e-technik.tu-muenchen.de
Solaris/SPARC native & host (devolved)
Michael Snyder msnyder@redhat.com
+QNX Neutrino i386 native & remote
+ Kris Warkentin kewarken@qnx.com
next prev parent reply other threads:[~2003-02-22 4:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-21 22:25 Kris Warkentin
2003-02-22 2:04 ` Kevin Buettner
2003-02-22 4:33 ` Kris Warkentin [this message]
2003-02-22 6:14 ` Daniel Jacobowitz
2003-02-24 16:04 ` Kris Warkentin
[not found] ` <1030222021025.ZM18868@localhost.localdomain>
[not found] ` <003301c2da28$71ce7ce0$2a00a8c0@dash>
[not found] ` <3E5A4ABD.1080706@redhat.com>
2003-02-24 16:53 ` Add Kris Warkentin to write after maintainers Kris Warkentin
2003-02-24 17:11 ` Andrew Cagney
2003-02-24 17:16 ` Kris Warkentin
2003-02-24 18:00 ` Kris Warkentin
2003-02-24 18:10 ` Andrew Cagney
2003-02-24 18:40 ` David Carlton
2003-02-24 20:01 ` Andrew Cagney
2003-02-24 20:12 ` Kris Warkentin
2003-02-24 18:50 ` Daniel Jacobowitz
2003-02-24 20:04 ` Andrew Cagney
2003-02-24 20:18 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004501c2da2b$efdb49d0$2a00a8c0@dash' \
--to=kewarken@qnx.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox