Re: [patch] New m32r remote target, m32rsdi

["Kei Sakamoto" <sakamoto.kei@renesas.com>]

Hello,

I posted the following two weeks ago, but there is no reaction
so far.

Its patch adds a new remote protocol to m32r architecture and
does not influence any other functions. So I think it's safe
to add.

I'm going to commit it next weak. Please let me know if there
is any problem.

Kei Sakamoto


From: "Kei Sakamoto" <sakamoto.kei@renesas.com>
To: "Daniel Jacobowitz" <drow@mvista.com>
Cc: <gdb-patches@sources.redhat.com>
Sent: Thursday, August 21, 2003 1:31 PM
Subject: Re: [patch] New m32r remote target, m32rsdi


> > On Mon, Aug 04, 2003 at 05:00:55PM +0900, Kei Sakamoto wrote:
> > > Hello,
> > > 
> > > The attached adds a new remote target, m32rsdi, which uses
> > > m32r's on-chip debug interface, SDI (Scalable Debug Interface).
> > > 
> > > In m32rsdi target mode, gdb does not control a target board
> > > directly. Instead, gdb sends commands to "sdiserver" by sockets
> > > interface. Sdiserver is a program which controls the target
> > > board using printer ports.
> > > 
> > > Is this OK to commit?
> > > 
> > > Kei Sakamoto
> > > 
> > > ====
> > > 
> > > 2003-08-04    Kei Sakamoto  <sakamoto.kei@renesas.com>
> > > 
> > > 
> > > * remote-m32r-sdi.c : New file, interface to m32r on-chip 
> > > debug interface, SDI (Scalable Debug Interface).
> > > * Makefile.in (remote-m32r-sdi.o): Add build rule.
> > > * config/m32r/m32r.mt (TDEPFILES) : Add remote-m32r-sdi.o.
> > 
> > I don't feel qualified to review a new remote target, so you'll have to
> > ask the remote maintainer.  However, there's definitely a problem with
> > the new code.  It's full of pieces like:
> > 
> >   if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
> >     *((unsigned long *) (buf + 1)) = pc_addr;
> >   else
> >     *((unsigned long *) (buf + 1)) = pc_addr - 1;
> > 
> > This sends host-endian data over the wire to the target.  Run it on a
> > big-endian host and bad things will happen.
> 
> Thank you for reviewing my patch. I revised it and removed
> the endian problem.
> 
> I've tested the attached patch on both Linux/Pentium-III and
> Soralis/Sparc4. So it works fine on both little-endian host
> and big-endian host.
> 
> Kei Sakamoto
> 
> ====
> 
> 2003-08-21    Kei Sakamoto  <sakamoto.kei@renesas.com>
> 
> * remote-m32r-sdi.c : New file, interface to m32r on-chip 
> debug interface, SDI (Scalable Debug Interface).
> * Makefile.in (remote-m32r-sdi.o): Add build rule.
> * config/m32r/m32r.mt (TDEPFILES) : Add remote-m32r-sdi.o.
>